mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: levon@movementarian.org
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, cliffw@osdl.org
Subject: [PATCH][OPROFILE] disable preempt when calling smp_processor_id()
Date: Fri, 5 Nov 2004 16:32:21 -0800	[thread overview]
Message-ID: <20041105163221.J14339@build.pdx.osdl.net> (raw)

Oprofile is hitting many of the below BUG messages.

BUG: using smp_processor_id() in preemptible [00000001] code: sleep/4892
caller is task_exit_notify+0x9/0x17
Call Trace: <ffffffff802ac70f>{smp_processor_id+191}
	    <ffffffff803ff219>{task_exit_notify+9}
	    <ffffffff8014a930>{notifier_call_chain+32}
	    <ffffffff8013d181>{profile_task_exit+49}
	    <ffffffff8013eb22>{do_exit+34}
	    <ffffffff80146490>{process_timeout+0}
	    <ffffffff8013f8c8>{do_group_exit+264}
	    <ffffffff801106b6>{system_call+126}

smp_processor_id() is called w/out preempt disabled.  Use
get_cpu()/put_cpu() instead.  Should this be put_cpu_no_resched()?

Signed-off-by: Chris Wright <chrisw@osdl.org>

--- linux-2.6.10-rc1-mm3-smp_processor_id/drivers/oprofile/buffer_sync.c~orig	2004-11-05 15:21:21.551984200 -0800
+++ linux-2.6.10-rc1-mm3-smp_processor_id/drivers/oprofile/buffer_sync.c	2004-11-05 15:23:29.000000000 -0800
@@ -62,7 +62,8 @@
 	/* To avoid latency problems, we only process the current CPU,
 	 * hoping that most samples for the task are on this CPU
 	 */
-	sync_buffer(smp_processor_id());
+	sync_buffer(get_cpu());
+	put_cpu();
   	return 0;
 }
 
@@ -86,7 +87,8 @@
 		/* To avoid latency problems, we only process the current CPU,
 		 * hoping that most samples for the task are on this CPU
 		 */
-		sync_buffer(smp_processor_id());
+		sync_buffer(get_cpu());
+		put_cpu();
 		return 0;
 	}
 

             reply	other threads:[~2004-11-06  0:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-06  0:32 Chris Wright [this message]
2004-11-07 16:56 ` John Levon
2004-11-08 17:11   ` Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041105163221.J14339@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=akpm@osdl.org \
    --cc=cliffw@osdl.org \
    --cc=levon@movementarian.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®