mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: John Levon <levon@movementarian.org>
Cc: Chris Wright <chrisw@osdl.org>,
	akpm@osdl.org, linux-kernel@vger.kernel.org, cliffw@osdl.org
Subject: Re: [PATCH][OPROFILE] disable preempt when calling smp_processor_id()
Date: Mon, 8 Nov 2004 09:11:45 -0800	[thread overview]
Message-ID: <20041108091145.D2357@build.pdx.osdl.net> (raw)
In-Reply-To: <20041107165623.GA36328@compsoc.man.ac.uk>; from levon@movementarian.org on Sun, Nov 07, 2004 at 04:56:23PM +0000

* John Levon (levon@movementarian.org) wrote:
> On Fri, Nov 05, 2004 at 04:32:21PM -0800, Chris Wright wrote:
> > smp_processor_id() is called w/out preempt disabled.  Use
> > get_cpu()/put_cpu() instead.  Should this be put_cpu_no_resched()?
> 
> No, the patch below looks fine

I realized over the weekend that it's still broken.  And Cliff hit it
in some tests he ran here.  The sync_buffer() function can sleep, and
while the unprotected call to smp_processor_id() is no longer a problem,
scheduling with preempt disabled is.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

      reply	other threads:[~2004-11-08 17:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-06  0:32 Chris Wright
2004-11-07 16:56 ` John Levon
2004-11-08 17:11   ` Chris Wright [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041108091145.D2357@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=akpm@osdl.org \
    --cc=cliffw@osdl.org \
    --cc=levon@movementarian.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®