[patch 1/2] Kbuild: avoid backup localversion files

[patch 1/2] Kbuild: avoid backup localversion files

[blaisorblade_spam]

From: Paolo 'Blaisorblade' Giarrusso <blaisorblade_spam@yahoo.it>
Cc: Sam Ravnborg <sam@ravnborg.org>

(Please CC me on replies as I'm not subscribed).

Avoid including as localversion-files the *~ files, i.e. backup files. If I
have localversion-a and localversion-a~, I don't want both to be used. Nor I
want to use localversion*~ anyway.

Don't code that as $(wildcard localversion*[^~]) as that would exclude
"localversion" from the wildcard expansion result, because it requires at
least one character after localversion to exist in the name file. I.e., 

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade_spam@yahoo.it>
---

 vanilla-linux-2.6.9-paolo/Makefile |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN Makefile~avoid-backup-localversion Makefile
--- vanilla-linux-2.6.9/Makefile~avoid-backup-localversion	2004-11-03 00:16:50.651772000 +0100
+++ vanilla-linux-2.6.9-paolo/Makefile	2004-11-03 00:16:50.654771544 +0100
@@ -156,7 +156,7 @@ localversion-files := $(wildcard $(objtr
 endif
 
 LOCALVERSION = $(subst $(space),, \
-	       $(shell cat /dev/null $(localversion-files)) \
+	       $(shell cat /dev/null $(localversion-files:%~=)) \
 	       $(patsubst "%",%,$(CONFIG_LOCALVERSION)))
 
 KERNELRELEASE=$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION)$(LOCALVERSION)
_

Re: [patch 1/2] Kbuild: avoid backup localversion files

[Sam Ravnborg]

On Wed, Nov 03, 2004 at 12:19:57AM +0100, blaisorblade_spam@yahoo.it wrote:
> 
> From: Paolo 'Blaisorblade' Giarrusso <blaisorblade_spam@yahoo.it>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> 
> (Please CC me on replies as I'm not subscribed).
> 
> Avoid including as localversion-files the *~ files, i.e. backup files. If I
> have localversion-a and localversion-a~, I don't want both to be used. Nor I
> want to use localversion*~ anyway.
> 
> Don't code that as $(wildcard localversion*[^~]) as that would exclude
> "localversion" from the wildcard expansion result, because it requires at
> least one character after localversion to exist in the name file. I.e., 

Applied,

	Sam