From: <Andries.Brouwer@cwi.nl>
To: akpm@osdl.org, torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] __devinit in sound/oss/es1371.c
Date: Sat, 13 Nov 2004 17:38:00 +0100 (MET) [thread overview]
Message-ID: <200411131638.iADGc0p09242@apps.cwi.nl> (raw)
It is forbidden to refer from __devinit to __init.
(Unless one argues that in the given situation hotplugging is
actually impossible. Too ugly.)
However, es1371_probe() is __devinit and referred to __initdata initvol[]
and to __init src_init().
diff -uprN -X /linux/dontdiff a/sound/oss/es1371.c b/sound/oss/es1371.c
--- a/sound/oss/es1371.c 2004-08-26 22:05:52.000000000 +0200
+++ b/sound/oss/es1371.c 2004-11-13 17:11:31.000000000 +0100
@@ -637,7 +637,7 @@ static void set_dac2_rate(struct es1371_
/* --------------------------------------------------------------------- */
-static void __init src_init(struct es1371_state *s)
+static void __devinit src_init(struct es1371_state *s)
{
unsigned int i;
@@ -2754,7 +2754,7 @@ MODULE_LICENSE("GPL");
static struct initvol {
int mixch;
int vol;
-} initvol[] __initdata = {
+} initvol[] __devinitdata = {
{ SOUND_MIXER_WRITE_LINE, 0x4040 },
{ SOUND_MIXER_WRITE_CD, 0x4040 },
{ MIXER_WRITE(SOUND_MIXER_VIDEO), 0x4040 },
reply other threads:[~2004-11-13 16:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411131638.iADGc0p09242@apps.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®