* [PATCH] __devinit in sound/oss/es1371.c
@ 2004-11-13 16:38 Andries.Brouwer
0 siblings, 0 replies; only message in thread
From: Andries.Brouwer @ 2004-11-13 16:38 UTC (permalink / raw)
To: akpm, torvalds; +Cc: linux-kernel
It is forbidden to refer from __devinit to __init.
(Unless one argues that in the given situation hotplugging is
actually impossible. Too ugly.)
However, es1371_probe() is __devinit and referred to __initdata initvol[]
and to __init src_init().
diff -uprN -X /linux/dontdiff a/sound/oss/es1371.c b/sound/oss/es1371.c
--- a/sound/oss/es1371.c 2004-08-26 22:05:52.000000000 +0200
+++ b/sound/oss/es1371.c 2004-11-13 17:11:31.000000000 +0100
@@ -637,7 +637,7 @@ static void set_dac2_rate(struct es1371_
/* --------------------------------------------------------------------- */
-static void __init src_init(struct es1371_state *s)
+static void __devinit src_init(struct es1371_state *s)
{
unsigned int i;
@@ -2754,7 +2754,7 @@ MODULE_LICENSE("GPL");
static struct initvol {
int mixch;
int vol;
-} initvol[] __initdata = {
+} initvol[] __devinitdata = {
{ SOUND_MIXER_WRITE_LINE, 0x4040 },
{ SOUND_MIXER_WRITE_CD, 0x4040 },
{ MIXER_WRITE(SOUND_MIXER_VIDEO), 0x4040 },
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-11-13 16:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-13 16:38 [PATCH] __devinit in sound/oss/es1371.c Andries.Brouwer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®