From: Ravikiran G Thirumalai <kiran@in.ibm.com>
To: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Kai Makisara <Kai.Makisara@metla.fi>,
Willem Riede <osst@riede.org>,
coda@cs.cmu.edu, Paul Mackerras <paulus@samba.org>
Subject: [patch 0/4] Cleanup file_count usage
Date: Tue, 16 Nov 2004 19:22:00 +0530 [thread overview]
Message-ID: <20041116135200.GA23257@impedimenta.in.ibm.com> (raw)
This patchset is an attempt to cleanup some bogus and some not so bogus
reads to struct file.f_count of the vfs from various subsystems in the
kernel. This patchset doesn't cleanup uses of f_count completely;
Geting rid of all reads to f_count was suggested by Viro during the discussion
on kref based lockfree fd management sometime back.
This cleans up:
1. Wrong usage of f_count in .open and .release routines of some file
systems
2. Error messages and warnings based on reads to f_count
3. Redundant check based on file_count in the vfs
4. Usage of file_count in hugetlb to report number of attaches
Patchset to follow.
What remains:
1. Hack to return error code to user space at last close through file_count
check at the driver's flush routine. This hack is used in scsi/st.c,
scsi/osst.c and coda/file.c to return error code through .flush()
(Although it is doubtful if applications check for error during close(2)).
Kai has a patch to cleanup scsi/st.c. I will make patches to move last
close code from .flush() to .release() in the coda filesystem if no one
objects to it. Not sure if you can do anything on errors at close...
Suggestions on alternatives welcome.
2. Read to f_count at drivers/net/ppp_generic.c:
The PPPIOCDETACH ioctl is failed if the device fd is duped and
being polled by another process -- which is determined by a read
to f_count. The comments in the code indicate that the PPPIOCDETACH
ioctl should be junked and userland can use a workaround
by closing the fd and reopening /dev/ppp. I can make a patch to junk
PPPIOCDETACH, but is it okay to break binary compatibility? Paul?
3. Usage of file_count in the AF_UNIX garbage collector (unix_gc)
Thanks,
Kiran
next reply other threads:[~2004-11-16 13:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-16 13:52 Ravikiran G Thirumalai [this message]
2004-11-16 13:57 ` [patch 1/4] Cleanup file_count usage: Bad usage at some .open, .release Ravikiran G Thirumalai
2004-11-16 14:03 ` [patch 2/4] Cleanup file_count usage: Error/debug messages on f_count reads Ravikiran G Thirumalai
2004-11-16 14:06 ` [patch 3/4] Cleanup file_count usage: Redundant check based on file_count Ravikiran G Thirumalai
2004-11-16 14:11 ` [patch 4/4] Cleanup file_count usage: Avoid file_count usage for hugetlb nattach reporting Ravikiran G Thirumalai
2004-11-16 14:24 ` William Lee Irwin III
2004-11-16 22:31 ` [patch 0/4] Cleanup file_count usage Paul Mackerras
2004-11-17 16:50 ` Ravikiran G Thirumalai
2004-11-17 22:07 ` Paul Mackerras
2004-12-01 6:30 ` Ravikiran G Thirumalai
2004-11-16 22:56 ` Jan Harkes
2004-11-16 23:19 ` Jan Harkes
2004-11-17 0:57 ` Willem Riede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041116135200.GA23257@impedimenta.in.ibm.com \
--to=kiran@in.ibm.com \
--cc=Kai.Makisara@metla.fi \
--cc=akpm@osdl.org \
--cc=coda@cs.cmu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=osst@riede.org \
--cc=paulus@samba.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome