mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keiichiro Tokunaga <tokunaga.keiich@jp.fujitsu.com>
To: linux-kernel@vger.kernel.org
Cc: Keiichiro Tokunaga <tokunaga.keiich@jp.fujitsu.com>
Subject: [PATCH] fix unnecessary increment in firmware_class_hotplug()
Date: Thu, 25 Nov 2004 20:19:35 +0900	[thread overview]
Message-ID: <20041125201935.213944c9.tokunaga.keiich@jp.fujitsu.com> (raw)

  This patch is to fix unnecessary increment of 'i' used to
specify an element of an arry 'envp[]' in firmware_class_hotplug().
The 'i' is already incremented in add_hotplug_env_var(), actually.

Thanks,
Keiichiro Tokunaga

Signed-off-by: Keiichiro Tokunaga <tokunaga.keiich@jp.fujitsu.com>
Status: Compiled on 2.6.10-rc2-mm3
---

 linux-2.6.10-rc2-mm3-kei/drivers/base/firmware_class.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/base/firmware_class.c~fix_firmware_class_hotplug drivers/base/firmware_class.c
--- linux-2.6.10-rc2-mm3/drivers/base/firmware_class.c~fix_firmware_class_hotplug	2004-11-25 18:31:19.278701104 +0900
+++ linux-2.6.10-rc2-mm3-kei/drivers/base/firmware_class.c	2004-11-25 18:31:37.555922544 +0900
@@ -103,7 +103,7 @@ firmware_class_hotplug(struct class_devi
 			"FIRMWARE=%s", fw_priv->fw_id))
 		return -ENOMEM;
 
-	envp[i++] = NULL;
+	envp[i] = NULL;
 
 	return 0;
 }

_


             reply	other threads:[~2004-11-26 20:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-25 11:19 Keiichiro Tokunaga [this message]
2004-11-26 20:30 ` Marcel Holtmann
2004-11-29 19:07   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041125201935.213944c9.tokunaga.keiich@jp.fujitsu.com \
    --to=tokunaga.keiich@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®