From: Greg KH <greg@kroah.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Keiichiro Tokunaga <tokunaga.keiich@jp.fujitsu.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] fix unnecessary increment in firmware_class_hotplug()
Date: Mon, 29 Nov 2004 11:07:20 -0800 [thread overview]
Message-ID: <20041129190720.GB15452@kroah.com> (raw)
In-Reply-To: <1101501024.6514.52.camel@pegasus>
On Fri, Nov 26, 2004 at 09:30:24PM +0100, Marcel Holtmann wrote:
> Hi Keiichiro,
>
> > This patch is to fix unnecessary increment of 'i' used to
> > specify an element of an arry 'envp[]' in firmware_class_hotplug().
> > The 'i' is already incremented in add_hotplug_env_var(), actually.
>
> you are right. The incrementation is wrong, but it doesn't have any
> negative effect. However the same applies for the usb_hotplug() function
> in drivers/usb/core/usb.c.
>
> > Signed-off-by: Keiichiro Tokunaga <tokunaga.keiich@jp.fujitsu.com>
>
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Applied, thanks.
greg k-h
prev parent reply other threads:[~2004-11-29 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-25 11:19 Keiichiro Tokunaga
2004-11-26 20:30 ` Marcel Holtmann
2004-11-29 19:07 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041129190720.GB15452@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=tokunaga.keiich@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome