From: Mikael Pettersson <mikpe@csd.uu.se>
To: marcelo.tosatti@cyclades.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH][2.4.29-pre1] proc_tty.c warning fix
Date: Sun, 28 Nov 2004 15:26:45 +0100 (MET) [thread overview]
Message-ID: <200411281426.iASEQjDt001350@harpo.it.uu.se> (raw)
The /proc/tty/driver/serial vulnerability fix in 2.4.29-pre1
calls a function without a prototype in scope, resulting in:
proc_tty.c: In function `proc_tty_init':
proc_tty.c:183: warning: implicit declaration of function `proc_mkdir_mode'
proc_tty.c:183: warning: assignment makes pointer from integer without a cast
Fixed by the trivial patch below.
Signed-off-by: Mikael Pettersson <mikpe@csd.uu.se>
--- linux-2.4.29-pre1/include/linux/proc_fs.h.~1~ 2004-11-28 12:54:26.000000000 +0100
+++ linux-2.4.29-pre1/include/linux/proc_fs.h 2004-11-28 13:44:05.000000000 +0100
@@ -143,6 +143,7 @@ extern struct proc_dir_entry *proc_symli
struct proc_dir_entry *, const char *);
extern struct proc_dir_entry *proc_mknod(const char *,mode_t,
struct proc_dir_entry *,kdev_t);
+extern struct proc_dir_entry *proc_mkdir_mode(const char *, mode_t, struct proc_dir_entry *);
extern struct proc_dir_entry *proc_mkdir(const char *,struct proc_dir_entry *);
static inline struct proc_dir_entry *create_proc_read_entry(const char *name,
next reply other threads:[~2004-11-28 14:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-28 14:26 Mikael Pettersson [this message]
2004-11-30 2:22 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411281426.iASEQjDt001350@harpo.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®