From: Chris Wright <chrisw@osdl.org>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: marcelo.tosatti@cyclades.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2.4.29-pre1] proc_tty.c warning fix
Date: Mon, 29 Nov 2004 18:22:00 -0800 [thread overview]
Message-ID: <20041129182159.H14339@build.pdx.osdl.net> (raw)
In-Reply-To: <200411281426.iASEQjDt001350@harpo.it.uu.se>; from mikpe@csd.uu.se on Sun, Nov 28, 2004 at 03:26:45PM +0100
* Mikael Pettersson (mikpe@csd.uu.se) wrote:
> The /proc/tty/driver/serial vulnerability fix in 2.4.29-pre1
> calls a function without a prototype in scope, resulting in:
>
> proc_tty.c: In function `proc_tty_init':
> proc_tty.c:183: warning: implicit declaration of function `proc_mkdir_mode'
> proc_tty.c:183: warning: assignment makes pointer from integer without a cast
>
> Fixed by the trivial patch below.
>
> Signed-off-by: Mikael Pettersson <mikpe@csd.uu.se>
Yes, oversight, please apply. Well, here's an insignificant variation
which comes straight from 2.6 to minimize divergence.
===== include/linux/proc_fs.h 1.10 vs edited =====
--- 1.10/include/linux/proc_fs.h 2004-10-05 11:22:37 -07:00
+++ edited/include/linux/proc_fs.h 2004-11-29 18:17:37 -08:00
@@ -144,6 +144,8 @@ extern struct proc_dir_entry *proc_symli
extern struct proc_dir_entry *proc_mknod(const char *,mode_t,
struct proc_dir_entry *,kdev_t);
extern struct proc_dir_entry *proc_mkdir(const char *,struct proc_dir_entry *);
+extern struct proc_dir_entry *proc_mkdir_mode(const char *name, mode_t mode,
+ struct proc_dir_entry *parent);
static inline struct proc_dir_entry *create_proc_read_entry(const char *name,
mode_t mode, struct proc_dir_entry *base,
prev parent reply other threads:[~2004-11-30 2:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-28 14:26 Mikael Pettersson
2004-11-30 2:22 ` Chris Wright [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041129182159.H14339@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=mikpe@csd.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®