mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: maneesh@in.ibm.com, akpm@osdl.org, chrisw@osdl.org,
	greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [Patch?] Teach sysfs_get_name not to use a dentry
Date: Wed, 1 Dec 2004 22:56:59 -0800	[thread overview]
Message-ID: <20041201225659.X2357@build.pdx.osdl.net> (raw)
In-Reply-To: <200412020641.iB26f8W26315@adam.yggdrasil.com>; from adam@yggdrasil.com on Wed, Dec 01, 2004 at 10:41:08PM -0800

* Adam J. Richter (adam@yggdrasil.com) wrote:
> -static int create_dir(struct kobject * k, struct dentry * p,
> -		      const char * n, struct dentry ** d)
> +static int create_dir(void *element, struct dentry * p,
> +		      const char * n, struct dentry ** d, int type)

Hmm, I did not look closely, but moving from well-typed to untyped void *
doesn't look nice.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

  reply	other threads:[~2004-12-02  6:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-02  6:41 Adam J. Richter
2004-12-02  6:56 ` Chris Wright [this message]
2004-12-02  7:00 ` Al Viro
2004-12-30 13:35 ` Maneesh Soni
2004-12-02  7:37 Adam J. Richter
2004-12-02  7:45 Adam J. Richter
2004-12-02 11:14 Adam J. Richter
2004-12-30 17:45 Adam J. Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041201225659.X2357@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=adam@yggdrasil.com \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maneesh@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome