mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* swsusp bugfixes: fix memory leak
@ 2004-12-11 15:44 Pavel Machek
  0 siblings, 0 replies; only message in thread
From: Pavel Machek @ 2004-12-11 15:44 UTC (permalink / raw)
  To: Andrew Morton, kernel list

Hi!

This fixes memory leak when we are low on memory during
suspend. Ouch and nr_needed_pages is only used twice, and only written
:-(. I guess that can wait for 2.6.10. Please apply,
							Pavel

--- clean/kernel/power/swsusp.c	28 Oct 2004 15:21:34 -0000	1.29
+++ linux/kernel/power/swsusp.c	10 Dec 2004 21:35:59 -0000
@@ -786,12 +768,13 @@
 
 int suspend_prepare_image(void)
 {
-	unsigned int nr_needed_pages = 0;
+	unsigned int nr_needed_pages;
 	int error;
 
 	pr_debug("swsusp: critical section: \n");
 	if (save_highmem()) {
 		printk(KERN_CRIT "Suspend machine: Not enough free pages for highmem\n");
+		restore_highmem();
 		return -ENOMEM;
 	}
 
 

-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-12-11 15:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-11 15:44 swsusp bugfixes: fix memory leak Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®