[PATCH 7/30] return statement cleanup - kill pointless parentheses in fs/xfs/xfs_fsops.c

[PATCH 7/30] return statement cleanup - kill pointless parentheses in fs/xfs/xfs_fsops.c

[Jesper Juhl]

This patch removes pointless parentheses from return statements in 
fs/xfs/xfs_fsops.c

Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>

--- linux-2.6.10-rc3-bk8-orig/fs/xfs/xfs_fsops.c	2004-10-18 23:55:06.000000000 +0200
+++ linux-2.6.10-rc3-bk8/fs/xfs/xfs_fsops.c	2004-12-15 22:44:07.000000000 +0100
@@ -520,7 +520,7 @@ xfs_reserve_blocks(
 	if (inval == (__uint64_t *)NULL) {
 		outval->resblks = mp->m_resblks;
 		outval->resblks_avail = mp->m_resblks_avail;
-		return(0);
+		return 0;
 	}
 
 	request = *inval;
@@ -556,7 +556,7 @@ xfs_reserve_blocks(
 	outval->resblks = mp->m_resblks;
 	outval->resblks_avail = mp->m_resblks_avail;
 	XFS_SB_UNLOCK(mp, s);
-	return(0);
+	return 0;
 }
 
 void

Re: [PATCH N/30] return statement cleanup - kill pointless parentheses in fs/xfs/*

[Nathan Scott]

On Thu, Dec 16, 2004 at 01:16:55AM +0100, Jesper Juhl wrote:
> This patch removes pointless parentheses from return statements in 
> fs/xfs/*
> 

Thanks, but no thanks.  This sort of "noise" diff makes comparing
new versions of a file/routine/... to older versions much more
difficult than need be, for no gain really.

cheers.

-- 
Nathan

Re: [PATCH N/30] return statement cleanup - kill pointless parentheses in fs/xfs/*

[Jesper Juhl]

On Thu, 16 Dec 2004, Nathan Scott wrote:

> On Thu, Dec 16, 2004 at 01:16:55AM +0100, Jesper Juhl wrote:
> > This patch removes pointless parentheses from return statements in 
> > fs/xfs/*
> > 
> 
> Thanks, but no thanks.  This sort of "noise" diff makes comparing
> new versions of a file/routine/... to older versions much more
> difficult than need be, for no gain really.
> 
Ok, fair enough, I'll strike fs/xfs/ from my todo list.  a few more are 
already send - just ignore those then, please.

Seems eople have different oppinions on this.....

-- 
Jesper Juhl