* [patch 2/2] linux-2.6.9/fs/proc/proc_tty.c: avoid array
@ 2004-12-25 15:35 domen
0 siblings, 0 replies; 2+ messages in thread
From: domen @ 2004-12-25 15:35 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, domen, wharms
Hi list,
no need for an array here. therefor no need to worry about possible
overflows. seq_printf() can handle this.
avoid array in show_tty_range()
re,
walter
signed-off-by: walter harms <wharms@bfs.de>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/fs/proc/proc_tty.c | 4 +---
1 files changed, 1 insertion(+), 3 deletions(-)
diff -puN fs/proc/proc_tty.c~remove_sprintf-fs_proc_proc_tty.c.bak fs/proc/proc_tty.c
--- kj/fs/proc/proc_tty.c~remove_sprintf-fs_proc_proc_tty.c.bak 2004-12-25 01:36:07.000000000 +0100
+++ kj-domen/fs/proc/proc_tty.c 2004-12-25 01:36:07.000000000 +0100
@@ -32,10 +32,8 @@ static void show_tty_range(struct seq_fi
seq_printf(m, "%-20s ", p->driver_name ? p->driver_name : "unknown");
seq_printf(m, "/dev/%-8s ", p->name);
if (p->num > 1) {
- char range[20];
- sprintf(range, "%d-%d", MINOR(from),
+ seq_printf(m, "%3d %d-%d ", MAJOR(from), MINOR(from),
MINOR(from) + num - 1);
- seq_printf(m, "%3d %7s ", MAJOR(from), range);
} else {
seq_printf(m, "%3d %7d ", MAJOR(from), MINOR(from));
}
diff -L fs/proc/proc_tty.c.bak -puN /dev/null /dev/null
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* [patch 2/2] linux-2.6.9/fs/proc/proc_tty.c: avoid array
@ 2004-12-25 14:26 domen
0 siblings, 0 replies; 2+ messages in thread
From: domen @ 2004-12-25 14:26 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, domen, wharms
Hi list,
no need for an array here. therefor no need to worry about possible
overflows. seq_printf() can handle this.
avoid array in show_tty_range()
re,
walter
signed-off-by: walter harms <wharms@bfs.de>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/fs/proc/proc_tty.c | 4 +---
1 files changed, 1 insertion(+), 3 deletions(-)
diff -puN fs/proc/proc_tty.c~remove_sprintf-fs_proc_proc_tty.c.bak fs/proc/proc_tty.c
--- kj/fs/proc/proc_tty.c~remove_sprintf-fs_proc_proc_tty.c.bak 2004-12-25 01:36:07.000000000 +0100
+++ kj-domen/fs/proc/proc_tty.c 2004-12-25 01:36:07.000000000 +0100
@@ -32,10 +32,8 @@ static void show_tty_range(struct seq_fi
seq_printf(m, "%-20s ", p->driver_name ? p->driver_name : "unknown");
seq_printf(m, "/dev/%-8s ", p->name);
if (p->num > 1) {
- char range[20];
- sprintf(range, "%d-%d", MINOR(from),
+ seq_printf(m, "%3d %d-%d ", MAJOR(from), MINOR(from),
MINOR(from) + num - 1);
- seq_printf(m, "%3d %7s ", MAJOR(from), range);
} else {
seq_printf(m, "%3d %7d ", MAJOR(from), MINOR(from));
}
diff -L fs/proc/proc_tty.c.bak -puN /dev/null /dev/null
_
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-12-25 15:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-25 15:35 [patch 2/2] linux-2.6.9/fs/proc/proc_tty.c: avoid array domen
-- strict thread matches above, loose matches on Subject: below --
2004-12-25 14:26 domen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®