Cannot compile without sysctl (+semi-patch)

Cannot compile without sysctl (+semi-patch)

[Jan Engelhardt]

Hi,


in trying to make the smallest possible kernel for an old pc's needs (read: 
386sx) disabling sysctl support (CONFIG_SYSCTL) does not work, sys_setgroups 
and sys_setgroups16 still require it. (I get a linking error.)
It's not a blocker, but it would be nice if this got wrapped up in #ifdef or 
something :-) so that either sysctl is always on or sys_setgroups behaves a 
little different.

Preferably:
include/linux/limits.h:
#ifdef __KERNEL__
extern int ngroups_max;
# define NGROUPS_MAX ngroups_max
#else
# define NGROUPS_MAX __NGROUPS_MAX
#endif

to

#if defined(__KERNEL__) && defined(CONFIG_SYSCTL)
# define NGROUPS_MAX ngroups_max
#else
# define NGROUPS_MAX __NGROUPS_MAX
#endif




Jan Engelhardt
-- 
ENOSPC

Re: Cannot compile without sysctl (+semi-patch)

[Adrian Bunk]

On Mon, Dec 27, 2004 at 06:06:35PM +0100, Jan Engelhardt wrote:

> Hi,

Hi Jan,

> in trying to make the smallest possible kernel for an old pc's needs (read: 
> 386sx) disabling sysctl support (CONFIG_SYSCTL) does not work, sys_setgroups 
> and sys_setgroups16 still require it. (I get a linking error.)
> It's not a blocker, but it would be nice if this got wrapped up in #ifdef or 
> something :-) so that either sysctl is always on or sys_setgroups behaves a 
> little different.
> 
> Preferably:
> include/linux/limits.h:
> #ifdef __KERNEL__
> extern int ngroups_max;
> # define NGROUPS_MAX ngroups_max
> #else
> # define NGROUPS_MAX __NGROUPS_MAX
> #endif
> 
> to
>...

you should also tell us which kernel version you observed this problem 
in - neither the latest 2.4 nor the latest 2.6 kernels have a limits.h 
like the one you describe...

> Jan Engelhardt

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: Cannot compile without sysctl (+semi-patch)

[Jan Engelhardt]

>> Preferably:
>> include/linux/limits.h:
>> #ifdef __KERNEL__
>> extern int ngroups_max;
>> # define NGROUPS_MAX ngroups_max
>> #else
>> # define NGROUPS_MAX __NGROUPS_MAX
>> #endif
>> 
>
>you should also tell us which kernel version you observed this problem 
>in - neither the latest 2.4 nor the latest 2.6 kernels have a limits.h 
>like the one you describe...

You'd spank me if I told you... :) SUSE KOTD 2004.12.02
That's a 2.6.8 + 2.6.9-rc2, plus a thousand patches.
Yeah, looks like it is kotd specific, never mind.
(patches.suse.tar.bz2#patches.suse/ngroups-max-var)


Jan Engelhardt
-- 
ENOSPC