From: Johannes Stezenbach <js@linuxtv.org>
To: Arne Ahrend <aahrend@web.de>
Cc: linux-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [linux-dvb-maintainer] PATCH: DVB bt8xx in 2.6.10
Date: Tue, 4 Jan 2005 19:11:53 +0100 [thread overview]
Message-ID: <20050104181153.GA1416@linuxtv.org> (raw)
In-Reply-To: <20050104175043.6a8fd195.aahrend@web.de>
Arne Ahrend wrote:
> This patch allows the user to select only actually desired frontend driver(s) for
> bt8xx based DVB cards by removing calls to frontend-specific XXX_attach()
> functions and returning NULL instead for unconfigured frontends.
>
> To keep this patch small, no attempt is made to #ifdef away other static functions or data
> for unselected frontends. This leads to compiler warnings about defined, but unused
> code, unless all four frontends relevant to bt8xx based cards are selected.
>
> I have tested this on the Avermedia 771 (the only DVB card I have access to).
This approach has been discussed on the linux-dvb list and was rejected
because of the huge #ifdef mess it creates (you just touched bt8xx, it's
even worse for saa7146 based cards). The frontend drivers are
tiny so I think you can afford to load some that aren't actually
used by your hardware.
Johannes
next prev parent reply other threads:[~2005-01-04 18:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-04 16:50 Arne Ahrend
2005-01-04 17:20 ` Manu Abraham
2005-01-04 18:11 ` Johannes Stezenbach [this message]
2005-01-06 11:24 ` [linux-dvb-maintainer] " Arne Ahrend
2005-01-06 12:13 ` [linux-dvb-maintainer] " Johannes Stezenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050104181153.GA1416@linuxtv.org \
--to=js@linuxtv.org \
--cc=aahrend@web.de \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome