From: Arne Ahrend <aahrend@web.de>
To: Johannes Stezenbach <js@linuxtv.org>
Cc: linux-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [linux-dvb-maintainer] PATCH: DVB bt8xx in 2.6.10
Date: Thu, 6 Jan 2005 12:24:09 +0100 [thread overview]
Message-ID: <20050106122409.195100bb.aahrend@web.de> (raw)
In-Reply-To: <20050104181153.GA1416@linuxtv.org>
On Tue, 4 Jan 2005 19:11:53 +0100
Johannes Stezenbach <js@linuxtv.org> wrote:
> This approach has been discussed on the linux-dvb list and was rejected
> because of the huge #ifdef mess it creates (you just touched bt8xx, it's
> even worse for saa7146 based cards). The frontend drivers are
> tiny so I think you can afford to load some that aren't actually
> used by your hardware.
Ok, point acknowledged. The following tiny bit of cosmetic might
be of interest anyway.
Arne
diff -upr -X dontdiff linux-2.6.10-vanilla/drivers/media/dvb/bt8xx/dvb-bt8xx.c linux-2.6.10/drivers/media/dvb/bt8xx/dvb-bt8xx.c
--- linux-2.6.10-vanilla/drivers/media/dvb/bt8xx/dvb-bt8xx.c 2005-01-04 15:36:33.000000000 +0100
+++ linux-2.6.10/drivers/media/dvb/bt8xx/dvb-bt8xx.c 2005-01-05 00:57:19.000000000 +0100
@@ -220,7 +220,7 @@ static int microtune_mt7202dtf_request_f
return request_firmware(fw, name, &bt->bt->dev->dev);
}
-struct sp887x_config microtune_mt7202dtf_config = {
+static struct sp887x_config microtune_mt7202dtf_config = {
.demod_address = 0x70,
.pll_set = microtune_mt7202dtf_pll_set,
diff -upr -X dontdiff linux-2.6.10-vanilla/drivers/media/dvb/bt8xx/dvb-bt8xx.h linux-2.6.10/drivers/media/dvb/bt8xx/dvb-bt8xx.h
--- linux-2.6.10-vanilla/drivers/media/dvb/bt8xx/dvb-bt8xx.h 2005-01-04 15:36:33.000000000 +0100
+++ linux-2.6.10/drivers/media/dvb/bt8xx/dvb-bt8xx.h 2005-01-05 00:58:39.000000000 +0100
@@ -22,6 +22,9 @@
*
*/
+#ifndef DVB_BT8XX_H
+#define DVB_BT8XX_H
+
#include <linux/i2c.h>
#include "dvbdev.h"
#include "dvb_net.h"
@@ -50,3 +53,5 @@ struct dvb_bt8xx_card {
struct dvb_frontend* fe;
};
+
+#endif /* DVB_BT8XX_H */
next prev parent reply other threads:[~2005-01-06 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-04 16:50 Arne Ahrend
2005-01-04 17:20 ` Manu Abraham
2005-01-04 18:11 ` [linux-dvb-maintainer] " Johannes Stezenbach
2005-01-06 11:24 ` Arne Ahrend [this message]
2005-01-06 12:13 ` [linux-dvb-maintainer] " Johannes Stezenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050106122409.195100bb.aahrend@web.de \
--to=aahrend@web.de \
--cc=js@linuxtv.org \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome