From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: riel@redhat.com, marcelo.tosatti@cyclades.com, andrea@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][5/?] count writeback pages in nr_scanned
Date: Wed, 5 Jan 2005 20:47:06 -0800 [thread overview]
Message-ID: <20050105204706.0781d672.akpm@osdl.org> (raw)
In-Reply-To: <41DCC014.80007@yahoo.com.au>
Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
> > If the queue is not congested, blk_congestion_wait() will still sleep. See
> > freed_request().
> >
>
> Hmm... doesn't look like it to me:
>
> if (rl->count[rw] < queue_congestion_off_threshold(q))
> clear_queue_congested(q, rw);
>
> And clear_queue_congested does an unconditional wakeup (if there
> is someone sleeping on the congestion queue).
That's my point. blk_congestion_wait() will always sleep, regardless of
the queue's congestion state.
next prev parent reply other threads:[~2005-01-06 4:47 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-03 17:25 Rik van Riel
2005-01-05 10:08 ` Andrew Morton
2005-01-05 18:06 ` Andrea Arcangeli
2005-01-05 18:50 ` Rik van Riel
2005-01-05 17:49 ` Marcelo Tosatti
2005-01-05 21:44 ` Andrew Morton
2005-01-05 20:32 ` Marcelo Tosatti
2005-01-05 23:51 ` Nick Piggin
2005-01-06 1:27 ` Rik van Riel
2005-01-06 1:33 ` Nick Piggin
2005-01-06 1:37 ` Andrew Morton
2005-01-06 1:40 ` Nick Piggin
2005-01-06 1:52 ` Andrea Arcangeli
2005-01-06 1:36 ` Andrew Morton
2005-01-06 3:42 ` Rik van Riel
2005-01-06 3:50 ` Nick Piggin
2005-01-06 4:26 ` Andrew Morton
2005-01-06 4:35 ` Nick Piggin
2005-01-06 4:47 ` Andrew Morton [this message]
2005-01-06 4:55 ` Nick Piggin
2005-01-06 5:03 ` Andrea Arcangeli
2005-01-06 8:06 ` Jens Axboe
2005-01-06 8:16 ` memory barrier in ll_rw_blk.c (was Re: [PATCH][5/?] count writeback pages in nr_scanned) Nick Piggin
2005-01-06 8:32 ` Jens Axboe
2005-01-06 8:53 ` Nick Piggin
2005-01-06 12:00 ` Jens Axboe
2005-01-06 4:59 ` [PATCH][5/?] count writeback pages in nr_scanned Andrea Arcangeli
2005-01-06 5:05 ` Andrew Morton
2005-01-06 5:17 ` Andrea Arcangeli
2005-01-06 5:19 ` Nick Piggin
2005-01-06 5:25 ` Andrea Arcangeli
2005-01-06 5:36 ` Nick Piggin
2005-01-06 5:44 ` Nick Piggin
2005-01-06 5:37 ` Andrew Morton
2005-01-06 5:59 ` Andrea Arcangeli
2005-01-06 13:28 ` Rik van Riel
2005-01-06 5:32 ` Andrew Morton
2005-01-06 5:46 ` Andrea Arcangeli
2005-01-06 5:59 ` Andrew Morton
2005-01-06 6:16 ` Andrea Arcangeli
2005-01-06 5:06 ` Nick Piggin
2005-01-06 5:21 ` Andrea Arcangeli
2005-01-05 23:26 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050105204706.0781d672.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=nickpiggin@yahoo.com.au \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome