mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] add EXPORT_SYMBOL for irq_exit
@ 2005-01-07  7:18 Heiko Carstens
  2005-01-07  7:29 ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Heiko Carstens @ 2005-01-07  7:18 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, hch

Hi Andrew,

this patch adds the missing EXPORT_SYMBOL for irq_exit:
*** Warning: "irq_exit" [drivers/s390/net/iucv.ko] undefined!

Please apply.

Thanks,
Heiko

diff -urN linux-2.6/kernel/softirq.c linux-2.6-patched/kernel/softirq.c
--- linux-2.6/kernel/softirq.c	2005-01-07 08:02:33.000000000 +0100
+++ linux-2.6-patched/kernel/softirq.c	2005-01-07 08:09:30.000000000 +0100
@@ -169,6 +169,8 @@
 	preempt_enable_no_resched();
 }
 
+EXPORT_SYMBOL(irq_exit);
+
 /*
  * This function must run with irqs disabled!
  */

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] add EXPORT_SYMBOL for irq_exit
  2005-01-07  7:18 [PATCH] add EXPORT_SYMBOL for irq_exit Heiko Carstens
@ 2005-01-07  7:29 ` Andrew Morton
  2005-01-07  7:53   ` Heiko Carstens
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2005-01-07  7:29 UTC (permalink / raw)
  To: Heiko Carstens; +Cc: linux-kernel, hch

Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
>
> this patch adds the missing EXPORT_SYMBOL for irq_exit:
>  *** Warning: "irq_exit" [drivers/s390/net/iucv.ko] undefined!

Why do s/390 drivers call irq_exit()?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] add EXPORT_SYMBOL for irq_exit
  2005-01-07  7:29 ` Andrew Morton
@ 2005-01-07  7:53   ` Heiko Carstens
  0 siblings, 0 replies; 3+ messages in thread
From: Heiko Carstens @ 2005-01-07  7:53 UTC (permalink / raw)
  To: Andrew Morton; +Cc: hch, linux-kernel

> > this patch adds the missing EXPORT_SYMBOL for irq_exit:
> >  *** Warning: "irq_exit" [drivers/s390/net/iucv.ko] undefined!
> 
> Why do s/390 drivers call irq_exit()?

Good question. Seems to be a bug in the iucv driver since irq_exit
might get called twice in an error case.
Just forget my "patch".

Heiko


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-01-07  7:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-07  7:18 [PATCH] add EXPORT_SYMBOL for irq_exit Heiko Carstens
2005-01-07  7:29 ` Andrew Morton
2005-01-07  7:53   ` Heiko Carstens

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®