From: Chris Wedgwood <cw@f00f.org>
To: Greg KH <greg@kroah.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] Enforce USB interface claims
Date: Sun, 23 Jan 2005 03:12:58 -0800 [thread overview]
Message-ID: <20050123111258.GA29513@taniwha.stupidest.org> (raw)
Greg,
How would you feel about something like this?
Index: cw-current/drivers/usb/core/devio.c
===================================================================
--- cw-current.orig/drivers/usb/core/devio.c 2005-01-19 14:52:27.987890276 -0800
+++ cw-current/drivers/usb/core/devio.c 2005-01-22 18:09:22.753895659 -0800
@@ -417,10 +417,7 @@
return -EINVAL;
if (test_bit(ifnum, &ps->ifclaimed))
return 0;
- /* if not yet claimed, claim it for the driver */
- dev_warn(&ps->dev->dev, "usbfs: process %d (%s) did not claim interface %u before use\n",
- current->pid, current->comm, ifnum);
- return claimintf(ps, ifnum);
+ return -EINVAL;
}
static int findintfep(struct usb_device *dev, unsigned int ep)
next reply other threads:[~2005-01-23 11:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-23 11:12 Chris Wedgwood [this message]
2005-01-25 6:05 ` Greg KH
2005-01-25 7:21 ` Chris Wedgwood
2005-01-25 8:27 ` Duncan Sands
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050123111258.GA29513@taniwha.stupidest.org \
--to=cw@f00f.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®