From: Duncan Sands <duncan.sands@math.u-psud.fr>
To: Greg KH <greg@kroah.com>
Cc: Chris Wedgwood <cw@f00f.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Enforce USB interface claims
Date: Tue, 25 Jan 2005 09:27:33 +0100 [thread overview]
Message-ID: <200501250927.33971.duncan.sands@math.u-psud.fr> (raw)
In-Reply-To: <20050125060555.GC2061@kroah.com>
> > - /* if not yet claimed, claim it for the driver */
> > - dev_warn(&ps->dev->dev, "usbfs: process %d (%s) did not claim interface %u before use\n",
> > - current->pid, current->comm, ifnum);
> > - return claimintf(ps, ifnum);
> > + return -EINVAL;
> > }
> >
> > static int findintfep(struct usb_device *dev, unsigned int ep)
>
>
> Um, why? I think this is there to help with "broken" userspace code
> that was written before we enforced the rules of "you must claim an
> interface before using it." As such, I don't think we can apply this
> patch.
Unfortunately it also means that there is no pressure to fix the user-space
code. How about having it say that the autoclaiming is deprecated, and will
be removed at some point?
Ciao,
Duncan.
prev parent reply other threads:[~2005-01-25 8:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-23 11:12 Chris Wedgwood
2005-01-25 6:05 ` Greg KH
2005-01-25 7:21 ` Chris Wedgwood
2005-01-25 8:27 ` Duncan Sands [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501250927.33971.duncan.sands@math.u-psud.fr \
--to=duncan.sands@math.u-psud.fr \
--cc=cw@f00f.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®