* [Patch] eth1394: Change KERN_ERR to KERN_INFO @ 2005-02-03 14:28 Steffen Zieger 2005-02-04 19:00 ` Jody McIntyre 0 siblings, 1 reply; 3+ messages in thread From: Steffen Zieger @ 2005-02-03 14:28 UTC (permalink / raw) To: linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 526 bytes --] Hello list, on boot eth1394 prints the following message to KERN_ERR, but I think it is better printing to KERN_INFO, because it _is_ an informational message only (or: I think so). This is the message I mean: eth1394: eth1: IEEE-1394 IPv4 over 1394 Ethernet (fw-host0) The patch should apply against kernel 2.6.11-rc2 cleanly HAND, Steffen -- Freiheit ist die Freiheit zu sagen, dass zwei und zwei gleich vier ist. Sobald das gewährleistet ist, ergibt sich alles andere von selbst. 1984 - George Orwell [-- Attachment #1.2: eth1394_KERN_ERR-2.6.11-rc2.patch --] [-- Type: text/x-diff, Size: 410 bytes --] --- drivers/ieee1394/eth1394.c.orig 2005-02-03 08:48:34.884410376 +0100 +++ drivers/ieee1394/eth1394.c 2005-02-03 08:48:58.948752040 +0100 @@ -626,7 +626,7 @@ goto out; } - ETH1394_PRINT (KERN_ERR, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n", + ETH1394_PRINT (KERN_INFO, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n", host->id); hi->host = host; [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] eth1394: Change KERN_ERR to KERN_INFO 2005-02-03 14:28 [Patch] eth1394: Change KERN_ERR to KERN_INFO Steffen Zieger @ 2005-02-04 19:00 ` Jody McIntyre 2005-02-05 19:26 ` Dan Dennedy 0 siblings, 1 reply; 3+ messages in thread From: Jody McIntyre @ 2005-02-04 19:00 UTC (permalink / raw) To: Steffen Zieger; +Cc: linux-kernel, linux1394-devel, dan On Thu, Feb 03, 2005 at 03:28:41PM +0100, Steffen Zieger wrote: > Hello list, > > on boot eth1394 prints the following message to KERN_ERR, but I think it is > better printing to KERN_INFO, because it _is_ an informational message only > (or: I think so). > This is the message I mean: > eth1394: eth1: IEEE-1394 IPv4 over 1394 Ethernet (fw-host0) > > The patch should apply against kernel 2.6.11-rc2 cleanly 1. Please add Signed-off-by (see Documentation/SubmittingPatches ). 2. Please produce patches that apply -p1. 3. Please cc linux1394-devel@lists.sourceforge.net. I made a new patch that applies to linux1394 SVN. Dan, if you agree with this change, please apply. Thanks, Jody > > HAND, > Steffen > -- > Freiheit ist die Freiheit zu sagen, dass zwei und zwei gleich vier ist. > Sobald das gew?hrleistet ist, ergibt sich alles andere von selbst. > 1984 - George Orwell > --- drivers/ieee1394/eth1394.c.orig 2005-02-03 08:48:34.884410376 +0100 > +++ drivers/ieee1394/eth1394.c 2005-02-03 08:48:58.948752040 +0100 > @@ -626,7 +626,7 @@ > goto out; > } > > - ETH1394_PRINT (KERN_ERR, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n", > + ETH1394_PRINT (KERN_INFO, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n", > host->id); > > hi->host = host; Change the initialization message for eth1394 to KERN_INFO, requested by Steffen Zieger <lkml@steffenspage.de> Signed-off-by: Jody McIntyre <scjody@modernduck.com> Index: ieee1394/eth1394.c =================================================================== --- ieee1394.orig/eth1394.c 2005-02-04 13:50:52.549918592 -0500 +++ ieee1394/eth1394.c 2005-02-04 13:53:04.648836504 -0500 @@ -625,7 +625,7 @@ static void ether1394_add_host (struct h goto out; } - ETH1394_PRINT (KERN_ERR, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n", + ETH1394_PRINT (KERN_INFO, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n", host->id); hi->host = host; ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] eth1394: Change KERN_ERR to KERN_INFO 2005-02-04 19:00 ` Jody McIntyre @ 2005-02-05 19:26 ` Dan Dennedy 0 siblings, 0 replies; 3+ messages in thread From: Dan Dennedy @ 2005-02-05 19:26 UTC (permalink / raw) To: Jody McIntyre; +Cc: Steffen Zieger, linux-kernel, Linux1394-Devel Committed On Fri, 2005-02-04 at 14:00 -0500, Jody McIntyre wrote: > Change the initialization message for eth1394 to KERN_INFO, requested > by > Steffen Zieger <lkml@steffenspage.de> > > Signed-off-by: Jody McIntyre <scjody@modernduck.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-05 19:33 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2005-02-03 14:28 [Patch] eth1394: Change KERN_ERR to KERN_INFO Steffen Zieger 2005-02-04 19:00 ` Jody McIntyre 2005-02-05 19:26 ` Dan Dennedy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®