mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: linux-kernel@vger.kernel.org
Subject: Re: 2.6.11-rc3: Kylix application no longer works?
Date: Tue, 8 Feb 2005 11:16:25 -0800	[thread overview]
Message-ID: <20050208111625.0bb1896d@dxpl.pdx.osdl.net> (raw)
In-Reply-To: <20050208175106.GA1091@elf.ucw.cz>

On Tue, 8 Feb 2005 18:51:06 +0100
Pavel Machek <pavel@ucw.cz> wrote:

> Hi!
> 
> > I wonder if reverting the patch will restore the old behaviour?
> 
> This seems to be minimal fix to get Kylix application back to the
> working state... Maybe it is good idea for 2.6.11?
> 
> Signed-off-by: Pavel Machek <pavel@suse.cz>
> 								Pavel
> 
> --- clean/fs/binfmt_elf.c	2005-02-03 22:27:19.000000000 +0100
> +++ linux/fs/binfmt_elf.c	2005-02-08 18:46:38.000000000 +0100
> @@ -803,11 +803,8 @@
>  				nbyte = ELF_MIN_ALIGN - nbyte;
>  				if (nbyte > elf_brk - elf_bss)
>  					nbyte = elf_brk - elf_bss;
> -				if (clear_user((void __user *) elf_bss + load_bias, nbyte)) {
> -					retval = -EFAULT;
> -					send_sig(SIGKILL, current, 0);
> -					goto out_free_dentry;
> -				}
> +				if (clear_user((void __user *) elf_bss + load_bias, nbyte))
> +					printk(KERN_ERR "Error clearing BSS, wrong ELF executable? (Kylix?!)\n");

do once or rate limit rather than log spamming.

-- 
Stephen Hemminger	<shemminger@osdl.org>

  reply	other threads:[~2005-02-08 19:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-07 22:11 Pavel Machek
2005-02-07 22:51 ` Andrew Morton
2005-02-08  0:03   ` Daniel Drake
2005-02-08  0:18     ` Andrew Morton
2005-02-08  0:56       ` Grzegorz Kulewski
2005-02-08  4:06         ` Andrew Morton
2005-02-08 17:13           ` Pavel Machek
2005-02-08  8:15       ` Daniel Drake
2005-02-08 17:27   ` Pavel Machek
2005-02-08 17:51   ` Pavel Machek
2005-02-08 19:16     ` Stephen Hemminger [this message]
2005-02-09  2:10       ` Andrew Morton
2005-02-09 11:11         ` Pavel Machek
2005-02-09 15:34         ` Daniel Jacobowitz
2005-02-09 20:13           ` Rik van Riel
2005-02-12  0:39             ` Ingo Oeser
2005-02-08 20:43     ` Daniel Jacobowitz
2005-02-08 22:27       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050208111625.0bb1896d@dxpl.pdx.osdl.net \
    --to=shemminger@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®