mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: Grzegorz Kulewski <kangur@polcom.net>,
	dsd@gentoo.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.11-rc3: Kylix application no longer works?
Date: Tue, 8 Feb 2005 18:13:15 +0100	[thread overview]
Message-ID: <20050208171315.GA1062@elf.ucw.cz> (raw)
In-Reply-To: <20050207200627.51c029cd.akpm@osdl.org>

Hi!

> >  > How should one set about reproducing this problem?
> > 
> >  IIRC, Some minimal "personal" version can be downloaded from borland.com.
> 
> Well I'd prefer that we not back out the whole patch.  Could someone please
> test with something like the below, let us know exactly where it's falling
> over?

Sorry, it seems your debugging traps do not trigger. I'll try other
patches...
								Pavel

> --- 25/fs/binfmt_elf.c~a	2005-02-07 20:01:16.000000000 -0800
> +++ 25-akpm/fs/binfmt_elf.c	2005-02-07 20:03:51.000000000 -0800
> @@ -44,6 +44,8 @@
>  
>  #include <linux/elf.h>
>  
> +#define D() do { printk("%s:%d\n", __FILE__, __LINE__); dump_stack(); } while (0)
> +
>  static int load_elf_binary(struct linux_binprm * bprm, struct pt_regs * regs);
>  static int load_elf_library(struct file*);
>  static unsigned long elf_map (struct file *, unsigned long, struct elf_phdr *, int, int);
> @@ -181,8 +183,10 @@ create_elf_tables(struct linux_binprm *b
>  			STACK_ALLOC(p, ((current->pid % 64) << 7));
>  #endif
>  		u_platform = (elf_addr_t __user *)STACK_ALLOC(p, len);
> -		if (__copy_to_user(u_platform, k_platform, len))
> +		if (__copy_to_user(u_platform, k_platform, len)) {
> +			D();
>  			return -EFAULT;
> +		}

-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

  reply	other threads:[~2005-02-08 17:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-07 22:11 Pavel Machek
2005-02-07 22:51 ` Andrew Morton
2005-02-08  0:03   ` Daniel Drake
2005-02-08  0:18     ` Andrew Morton
2005-02-08  0:56       ` Grzegorz Kulewski
2005-02-08  4:06         ` Andrew Morton
2005-02-08 17:13           ` Pavel Machek [this message]
2005-02-08  8:15       ` Daniel Drake
2005-02-08 17:27   ` Pavel Machek
2005-02-08 17:51   ` Pavel Machek
2005-02-08 19:16     ` Stephen Hemminger
2005-02-09  2:10       ` Andrew Morton
2005-02-09 11:11         ` Pavel Machek
2005-02-09 15:34         ` Daniel Jacobowitz
2005-02-09 20:13           ` Rik van Riel
2005-02-12  0:39             ` Ingo Oeser
2005-02-08 20:43     ` Daniel Jacobowitz
2005-02-08 22:27       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050208171315.GA1062@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@osdl.org \
    --cc=dsd@gentoo.org \
    --cc=kangur@polcom.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®