mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Nigel Cunningham <ncunningham@linuxmail.org>,
	Hu Gang <hugang@soulinfo.com>
Subject: Re: [RFC][PATCH] swsusp: do not use higher order allocations on resume [update 2]
Date: Tue, 8 Feb 2005 23:42:02 +0100	[thread overview]
Message-ID: <20050208224202.GD1347@elf.ucw.cz> (raw)
In-Reply-To: <200502081929.19503.rjw@sisk.pl>

Hi!

> +static inline void eat_page(void *page) {

Please put { on new line.

Okay, as you can see, I could find very little wrong with this
patch. That hopefully means it is okay ;-). I should still check error
handling, but I guess I'll do it when it is applied because it is hard
to do on a diff. I guess it should go into -mm just after 2.6.11 is
released...

								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

  parent reply	other threads:[~2005-02-08 22:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-30 23:19 [RFC][PATCH] swsusp: do not use higher order memory allocations on resume Rafael J. Wysocki
2005-01-31 23:19 ` [RFC][PATCH] swsusp: do not use higher order memory allocations [update] Rafael J. Wysocki
2005-02-07 11:08 ` [RFC][PATCH] swsusp: do not use higher order allocations on resume [update 2] Rafael J. Wysocki
2005-02-07 14:27   ` Pavel Machek
2005-02-07 14:45     ` Rafael J. Wysocki
2005-02-07 16:23   ` Pavel Machek
2005-02-08 18:29     ` Rafael J. Wysocki
2005-02-08 19:10       ` Pavel Machek
2005-02-08 22:28         ` Rafael J. Wysocki
2005-02-08 22:42       ` Pavel Machek [this message]
2005-02-08 23:22         ` Rafael J. Wysocki
2005-02-13  5:54           ` hugang
2005-02-13  6:11             ` hugang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050208224202.GD1347@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=hugang@soulinfo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@linuxmail.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®