From: hugang@soulinfo.com
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Pavel Machek <pavel@ucw.cz>, LKML <linux-kernel@vger.kernel.org>,
Nigel Cunningham <ncunningham@linuxmail.org>
Subject: Re: [RFC][PATCH] swsusp: do not use higher order allocations on resume [update 2]
Date: Sun, 13 Feb 2005 14:11:36 +0800 [thread overview]
Message-ID: <20050213061136.GA3820@hugang.soulinfo.com> (raw)
In-Reply-To: <19031231170827.GA3610@hugang.soulinfo.com>
On Sun, Feb 13, 2005 at 01:04:56PM +0706, hugang@soulinfo.com wrote:
> On Wed, Feb 09, 2005 at 12:22:52AM +0100, Rafael J. Wysocki wrote:
> > On Tuesday, 8 of February 2005 23:42, Pavel Machek wrote:
> > > Hi!
> > >
> > > > +static inline void eat_page(void *page) {
> > >
> > > Please put { on new line.
> >
> > Oh, I still tend to forget about this. Corrected in the patch that is
> > available on the web
> > (http://www.sisk.pl/kernel/patches/2.6.11-rc3-mm1/swsusp-use-list-resume-v4.patch).
> >
> >
> > > Okay, as you can see, I could find very little wrong with this
> > > patch. That hopefully means it is okay ;-). I should still check error
> > > handling, but I guess I'll do it when it is applied because it is hard
> > > to do on a diff. I guess it should go into -mm just after 2.6.11 is
> > > released...
> >
> > That would be great!
> >
> > Greets,
> > Rafael
>
> Here is powerpc port support for that. Thanks for greate patch.
>
Sorry I forgot this one.
--- 2.6.11-rc3-mm2-use-list-resume-v4/arch/ppc/kernel/asm-offsets.c 2004-12-30 14:55:39.000000000 +0800
+++ 2.6.11-rc3-mm2-use-list-resume-v4-ppc/arch/ppc/kernel/asm-offsets.c 2005-02-13 12:30:59.000000000 +0800
@@ -16,6 +16,7 @@
#include <linux/string.h>
#include <linux/types.h>
#include <linux/ptrace.h>
+#include <linux/suspend.h>
#include <linux/mman.h>
#include <linux/mm.h>
#include <asm/io.h>
@@ -136,6 +137,10 @@ main(void)
DEFINE(TI_CPU, offsetof(struct thread_info, cpu));
DEFINE(TI_PREEMPT, offsetof(struct thread_info, preempt_count));
+ DEFINE(pbe_address, offsetof(struct pbe, address));
+ DEFINE(pbe_orig_address, offsetof(struct pbe, orig_address));
+ DEFINE(pbe_next, offsetof(struct pbe, next));
+
DEFINE(NUM_USER_SEGMENTS, TASK_SIZE>>28);
return 0;
}
--
Hu Gang .-.
/v\
// \\
Linux User /( )\ [204016]
GPG Key ID ^^-^^ http://soulinfo.com/~hugang/hugang.asc
prev parent reply other threads:[~2005-02-13 6:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-30 23:19 [RFC][PATCH] swsusp: do not use higher order memory allocations on resume Rafael J. Wysocki
2005-01-31 23:19 ` [RFC][PATCH] swsusp: do not use higher order memory allocations [update] Rafael J. Wysocki
2005-02-07 11:08 ` [RFC][PATCH] swsusp: do not use higher order allocations on resume [update 2] Rafael J. Wysocki
2005-02-07 14:27 ` Pavel Machek
2005-02-07 14:45 ` Rafael J. Wysocki
2005-02-07 16:23 ` Pavel Machek
2005-02-08 18:29 ` Rafael J. Wysocki
2005-02-08 19:10 ` Pavel Machek
2005-02-08 22:28 ` Rafael J. Wysocki
2005-02-08 22:42 ` Pavel Machek
2005-02-08 23:22 ` Rafael J. Wysocki
2005-02-13 5:54 ` hugang
2005-02-13 6:11 ` hugang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050213061136.GA3820@hugang.soulinfo.com \
--to=hugang@soulinfo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@linuxmail.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®