* prism54 not releasing region
@ 2005-02-26 0:01 Panagiotis Issaris
2005-02-26 0:40 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Panagiotis Issaris @ 2005-02-26 0:01 UTC (permalink / raw)
To: prism54-devel; +Cc: linux-kernel
Hi,
To my newbie eye it looked as if the region requested at line 154
weren't released in case of the line 166 failure handling. Is
my assumption right?
With friendly regards,
Takis
diff -uprN linux-2.6.11-rc5-orig/drivers/net/wireless/prism54/islpci_hotplug.c linux-2.6.11-rc5-pi/drivers/net/wireless/prism54/islpci_hotplug.c
--- linux-2.6.11-rc5-orig/drivers/net/wireless/prism54/islpci_hotplug.c 2005-02-26 00:33:19.000000000 +0100
+++ linux-2.6.11-rc5-pi/drivers/net/wireless/prism54/islpci_hotplug.c 2005-02-26 00:34:13.000000000 +0100
@@ -163,7 +163,7 @@ prism54_probe(struct pci_dev *pdev, cons
if (rvalue || !mem_addr) {
printk(KERN_ERR "%s: PCI device memory region not configured; fix your BIOS or CardBus bridge/drivers\n",
DRV_NAME);
- goto do_pci_disable_device;
+ goto do_pci_release_regions;
}
/* enable PCI bus-mastering */
--
OpenPGP key: http://lumumba.luc.ac.be/takis/takis_public_key.txt
fingerprint: 6571 13A3 33D9 3726 F728 AA98 F643 B12E ECF3 E029
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: prism54 not releasing region
2005-02-26 0:40 ` Andrew Morton
@ 2005-02-26 0:39 ` Panagiotis Issaris
0 siblings, 0 replies; 3+ messages in thread
From: Panagiotis Issaris @ 2005-02-26 0:39 UTC (permalink / raw)
To: Andrew Morton; +Cc: takis, prism54-devel, linux-kernel
Andrew Morton wrote:
>Panagiotis Issaris <takis@lumumba.luc.ac.be> wrote:
>
>
>>To my newbie eye it looked as if the region requested at line 154
>>weren't released in case of the line 166 failure handling. Is
>>my assumption right?
>>
>>
>
>It is. I can take care of this patch for you, thanks.
>
>
Great! :-) Thanks!
With friendly regards,
Takis
--
K.U.Leuven, Mechanical Eng., Mechatronics & Robotics Research Group
http://people.mech.kuleuven.ac.be/~pissaris/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: prism54 not releasing region
2005-02-26 0:01 prism54 not releasing region Panagiotis Issaris
@ 2005-02-26 0:40 ` Andrew Morton
2005-02-26 0:39 ` Panagiotis Issaris
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2005-02-26 0:40 UTC (permalink / raw)
To: panagiotis.issaris; +Cc: takis, prism54-devel, linux-kernel
Panagiotis Issaris <takis@lumumba.luc.ac.be> wrote:
>
> To my newbie eye it looked as if the region requested at line 154
> weren't released in case of the line 166 failure handling. Is
> my assumption right?
It is. I can take care of this patch for you, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-02-26 0:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-02-26 0:01 prism54 not releasing region Panagiotis Issaris
2005-02-26 0:40 ` Andrew Morton
2005-02-26 0:39 ` Panagiotis Issaris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®