mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Andrew Morton <akpm@osdl.org>, torvalds@osdl.org
Cc: linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org,
	jt@hpl.hp.com
Subject: PCMCIA product id strings -> hashes generation at compilation time? [Was: Re: [patch 14/38] pcmcia: id_table for wavelan_cs]
Date: Tue, 8 Mar 2005 20:11:38 +0100	[thread overview]
Message-ID: <20050308191138.GA16169@isilmar.linta.de> (raw)
In-Reply-To: <20050307232339.GA30057@isilmar.linta.de>

Andrew, Linus, all,

[note: for detailed code please take a look at 2.6.11-mm2]

Most pcmcia devices are matched to drivers using "product ID strings"
embedded in the devices' Card Information Structures, as "manufactor ID /
card ID" matches are much less reliable. Unfortunately, these strings cannot
be passed to userspace for easy userspace-based loading of appropriate
modules (MODNAME -- hotplug), so my suggestion is to also store crc32 hashes
of the strings in the MODULE_DEVICE_TABLEs, e.g.:

PCMCIA_DEVICE_PROD_ID12("LINKSYS", "E-CARD", 0xf7cb0b07, 0x6701da11),

Only the hashes are stored in "modules.alias", and only the hashes
calculated upon device insertion are passed to userspace.

While having to determine the crc32 hashes is a hassle to device driver 
authors, I do not see a smart way to generate these (or similar) hashes 
automatically at compilation time:
	- the C preprocessor doesn't seem to be smart enough
	- scripts/mod/file2alias.c would need to learn all architectures
	  (and be cross-compilation aware) to relocate/dereference/access
	  strings saved as         
		const char *          prod_id[4];
	  in struct pcmcia_device_id s

To make the life easier for device driver authors,
	- a big warning is put into dmesg if a pcmcia driver is inserted
	  into the kernel and the hash mentioned in PCMCIA_DEVICE_PROD_ID()
	  is incorrect,
	- the hash can easily be calculated in userspace from existing
	  /etc/pcmcia/config files, from inserted PCMCIA cards and and and...,
	- I've added the appropriate hashes for all device matches for 
	  drivers in the base linux kernel.

Even though I'm a bit uncomfortable with this solution, I do not see any
other feasible way. Linus, Andrew, do you agree with this handling despite
all the troubles involved with it? 

	Dominik

       reply	other threads:[~2005-03-08 19:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050227161308.GO7351@dominikbrodowski.de>
     [not found] ` <20050307225355.GB30371@bougret.hpl.hp.com>
     [not found]   ` <20050307230102.GA29779@isilmar.linta.de>
     [not found]     ` <20050307150957.0456dd75.akpm@osdl.org>
     [not found]       ` <20050307232339.GA30057@isilmar.linta.de>
2005-03-08 19:11         ` Dominik Brodowski [this message]
2005-03-08 20:34           ` Andrew Morton
2005-03-08 22:54           ` Linus Torvalds
2005-03-08 23:16             ` Dominik Brodowski
2005-03-08 23:37               ` Greg KH
2005-03-08 23:46                 ` Dominik Brodowski
2005-03-08 23:39               ` Dominik Brodowski
2005-03-09  5:45               ` Benjamin Herrenschmidt
2005-03-09  6:00                 ` Greg KH
2005-03-09  7:21                   ` Benjamin Herrenschmidt
2005-03-09  7:19                 ` Dominik Brodowski
2005-03-09  7:36                   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050308191138.GA16169@isilmar.linta.de \
    --to=linux@dominikbrodowski.net \
    --cc=akpm@osdl.org \
    --cc=jt@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®