mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [patch 1/1] doc: describe Kbuild pitfall
@ 2005-03-19 16:58 blaisorblade
  0 siblings, 0 replies; only message in thread
From: blaisorblade @ 2005-03-19 16:58 UTC (permalink / raw)
  To: torvalds; +Cc: akpm, linux-kernel, blaisorblade, sam


From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Sam Ravnborg <sam@ravnborg.org>

Whitespace is significant for make, and I just fought against this... so
please apply this patch.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
---

 linux-2.6.11-paolo/Documentation/kbuild/makefiles.txt |    6 ++++++
 1 files changed, 6 insertions(+)

diff -puN Documentation/kbuild/makefiles.txt~doc-add-pitfall Documentation/kbuild/makefiles.txt
--- linux-2.6.11/Documentation/kbuild/makefiles.txt~doc-add-pitfall	2005-03-19 17:52:48.000000000 +0100
+++ linux-2.6.11-paolo/Documentation/kbuild/makefiles.txt	2005-03-19 17:53:57.000000000 +0100
@@ -872,7 +872,13 @@ When kbuild executes the following steps
 	Assignments to $(targets) are without $(obj)/ prefix.
 	if_changed may be used in conjunction with custom commands as
 	defined in 6.7 "Custom kbuild commands".
+
 	Note: It is a typical mistake to forget the FORCE prerequisite.
+	Another pitfall that bit me once is that whitespace is sometimes
+	significant; for instance, the below will fail (note the extra space
+	after the comma):
+		target: source(s) FORCE
+			$(call if_changed, ld/objcopy/gzip)
 
     ld
 	Link target. Often LDFLAGS_$@ is used to set specific options to ld.
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-03-20 10:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-19 16:58 [patch 1/1] doc: describe Kbuild pitfall blaisorblade

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®