From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>, Dave Jones <davej@redhat.com>,
Greg KH <greg@kroah.com>,
chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>,
Leendert van Doorn <leendert@watson.ibm.com>,
Reiner Sailer <sailer@watson.ibm.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH] alpha build fixes
Date: Sat, 19 Mar 2005 18:16:41 -0500 [thread overview]
Message-ID: <20050319231641.GA28070@havoc.gtf.org> (raw)
In-Reply-To: <20050319231116.GA4114@twiddle.net>
On Sat, Mar 19, 2005 at 03:11:16PM -0800, Richard Henderson wrote:
> On Fri, Mar 18, 2005 at 11:34:07PM -0500, Jeff Garzik wrote:
> > +/* TODO: integrate with include/asm-generic/pci.h ? */
> > +static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel)
> > +{
> > + return channel ? 15 : 14;
> > +}
>
> Am I missing something, or is this *only* used by drivers/ide/pci/amd74xx.c?
> Why in the world would we have this much infrastructure for one driver? And
> why not just not compile that one for Alpha, since it'll never be used.
My presumption is that it will be used in other IDE drivers in the
future. Bart?
If it will only be used in that one driver, then I agree.
Jeff
next prev parent reply other threads:[~2005-03-19 23:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-19 4:34 Jeff Garzik
2005-03-19 23:11 ` Richard Henderson
2005-03-19 23:16 ` Jeff Garzik [this message]
2005-03-21 8:05 ` Bartlomiej Zolnierkiewicz
2005-03-21 9:16 ` Ivan Kokshaysky
2005-03-21 9:45 ` Bartlomiej Zolnierkiewicz
2005-03-21 12:27 ` Benjamin Herrenschmidt
2005-03-21 13:53 ` Ivan Kokshaysky
2005-03-21 23:27 ` Benjamin Herrenschmidt
2005-03-21 14:52 ` Alan Cox
2005-03-21 18:16 ` Richard Henderson
2005-03-21 18:22 ` Jeff Garzik
2005-03-23 13:49 Matthew Wilcox
2007-12-13 9:21 [patch] alpha: " Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050319231641.GA28070@havoc.gtf.org \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=bzolnier@gmail.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=davej@redhat.com \
--cc=greg@kroah.com \
--cc=leendert@watson.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sailer@watson.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome