mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Jeff Garzik <jgarzik@pobox.com>, Andrew Morton <akpm@osdl.org>,
	Dave Jones <davej@redhat.com>, Greg KH <greg@kroah.com>,
	chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>,
	Leendert van Doorn <leendert@watson.ibm.com>,
	Reiner Sailer <sailer@watson.ibm.com>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] alpha build fixes
Date: Mon, 21 Mar 2005 16:53:10 +0300	[thread overview]
Message-ID: <20050321165310.A10078@jurassic.park.msu.ru> (raw)
In-Reply-To: <1111408059.25180.277.camel@gaston>; from benh@kernel.crashing.org on Mon, Mar 21, 2005 at 11:27:39PM +1100

On Mon, Mar 21, 2005 at 11:27:39PM +1100, Benjamin Herrenschmidt wrote:
> IRQs on IDE in legacy mode is sort of an out-of-spec piece of junk that
> was invented to make PCI based peecees "look like" good old rotten
> hardware, unfortunately, some modern and non-x86 HW vendors still don't
> haev a clue and configure (wire in some case) their on board IDE in
> legacy mode, but with IRQs that, on those archs, aren't 14 and 15. That
> hook fixes the problem on some ppc64 machines but should be extended to
> cover various other cases where similar shit happens.

Indeed, such setup is quite typical for southbridge chips with
integrated IDE controller - they still simulate sort of ISA IRQ
routing...

> It's in PCI because I figured it was as bad there than anywhere else. In
> this case, it's the IDE layer asking the PCI layer "hey, that guy
> doesn't respect the normal PCI IRQ mapping, can you tell me how it's
> routed ?" :) Back then, I didn't know of a header shared between ide and
> libata so I put it there.

Ok, but asm-generic/pci.h is not a good place for default IRQ 14/15 case -
this header cannot be included on non-x86 without additional #ifdef's.
Perhaps we can move it to linux/pci.h or linux/ata.h (as Bart noted)?

Ivan.

  reply	other threads:[~2005-03-21 13:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-19  4:34 Jeff Garzik
2005-03-19 23:11 ` Richard Henderson
2005-03-19 23:16   ` Jeff Garzik
2005-03-21  8:05     ` Bartlomiej Zolnierkiewicz
2005-03-21  9:16       ` Ivan Kokshaysky
2005-03-21  9:45         ` Bartlomiej Zolnierkiewicz
2005-03-21 12:27           ` Benjamin Herrenschmidt
2005-03-21 13:53             ` Ivan Kokshaysky [this message]
2005-03-21 23:27               ` Benjamin Herrenschmidt
2005-03-21 14:52   ` Alan Cox
2005-03-21 18:16     ` Richard Henderson
2005-03-21 18:22       ` Jeff Garzik
2005-03-23 13:49 Matthew Wilcox
2007-12-13  9:21 [patch] alpha: " Ivan Kokshaysky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050321165310.A10078@jurassic.park.msu.ru \
    --to=ink@jurassic.park.msu.ru \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=bzolnier@gmail.com \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=davej@redhat.com \
    --cc=greg@kroah.com \
    --cc=jgarzik@pobox.com \
    --cc=leendert@watson.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sailer@watson.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®