From: Petr Vandrovec <vandrove@vc.cvut.cz>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-fbdev-devel@lists.sourceforge.net,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][trivial] matroxfb_maven remove pointless semicolons after label
Date: Sun, 20 Mar 2005 20:17:28 +0100 [thread overview]
Message-ID: <20050320191728.GF32717@vana.vc.cvut.cz> (raw)
In-Reply-To: <Pine.LNX.4.62.0503201737250.2501@dragon.hyggekrogen.localhost>
On Sun, Mar 20, 2005 at 05:41:01PM +0100, Jesper Juhl wrote:
>
> Having a semicolon at the end as in labelname:; is pointless, remove.
As long as I'm maintainer of this code, I prefer to leave them here.
Petr Vandrovec
>
> Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
>
> diff -up linux-2.6.11-mm4-orig/drivers/video/matrox/matroxfb_maven.c linux-2.6.11-mm4/drivers/video/matrox/matroxfb_maven.c
> --- linux-2.6.11-mm4-orig/drivers/video/matrox/matroxfb_maven.c 2005-03-02 08:37:30.000000000 +0100
> +++ linux-2.6.11-mm4/drivers/video/matrox/matroxfb_maven.c 2005-03-20 17:35:48.000000000 +0100
> @@ -1263,11 +1263,11 @@ static int maven_detect_client(struct i2
> if (err)
> goto ERROR4;
> return 0;
> -ERROR4:;
> +ERROR4:
> i2c_detach_client(new_client);
> -ERROR3:;
> +ERROR3:
> kfree(new_client);
> -ERROR0:;
> +ERROR0:
> return err;
> }
>
>
>
>
next prev parent reply other threads:[~2005-03-20 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-20 16:41 Jesper Juhl
2005-03-20 19:17 ` Petr Vandrovec [this message]
2005-03-20 19:34 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050320191728.GF32717@vana.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=juhl-lkml@dif.dk \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®