* [PATCH][trivial] matroxfb_maven remove pointless semicolons after label
@ 2005-03-20 16:41 Jesper Juhl
2005-03-20 19:17 ` Petr Vandrovec
0 siblings, 1 reply; 3+ messages in thread
From: Jesper Juhl @ 2005-03-20 16:41 UTC (permalink / raw)
To: Petr Vandrovec; +Cc: linux-fbdev-devel, linux-kernel
Having a semicolon at the end as in labelname:; is pointless, remove.
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
diff -up linux-2.6.11-mm4-orig/drivers/video/matrox/matroxfb_maven.c linux-2.6.11-mm4/drivers/video/matrox/matroxfb_maven.c
--- linux-2.6.11-mm4-orig/drivers/video/matrox/matroxfb_maven.c 2005-03-02 08:37:30.000000000 +0100
+++ linux-2.6.11-mm4/drivers/video/matrox/matroxfb_maven.c 2005-03-20 17:35:48.000000000 +0100
@@ -1263,11 +1263,11 @@ static int maven_detect_client(struct i2
if (err)
goto ERROR4;
return 0;
-ERROR4:;
+ERROR4:
i2c_detach_client(new_client);
-ERROR3:;
+ERROR3:
kfree(new_client);
-ERROR0:;
+ERROR0:
return err;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][trivial] matroxfb_maven remove pointless semicolons after label
2005-03-20 16:41 [PATCH][trivial] matroxfb_maven remove pointless semicolons after label Jesper Juhl
@ 2005-03-20 19:17 ` Petr Vandrovec
2005-03-20 19:34 ` Jesper Juhl
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vandrovec @ 2005-03-20 19:17 UTC (permalink / raw)
To: Jesper Juhl; +Cc: linux-fbdev-devel, linux-kernel
On Sun, Mar 20, 2005 at 05:41:01PM +0100, Jesper Juhl wrote:
>
> Having a semicolon at the end as in labelname:; is pointless, remove.
As long as I'm maintainer of this code, I prefer to leave them here.
Petr Vandrovec
>
> Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
>
> diff -up linux-2.6.11-mm4-orig/drivers/video/matrox/matroxfb_maven.c linux-2.6.11-mm4/drivers/video/matrox/matroxfb_maven.c
> --- linux-2.6.11-mm4-orig/drivers/video/matrox/matroxfb_maven.c 2005-03-02 08:37:30.000000000 +0100
> +++ linux-2.6.11-mm4/drivers/video/matrox/matroxfb_maven.c 2005-03-20 17:35:48.000000000 +0100
> @@ -1263,11 +1263,11 @@ static int maven_detect_client(struct i2
> if (err)
> goto ERROR4;
> return 0;
> -ERROR4:;
> +ERROR4:
> i2c_detach_client(new_client);
> -ERROR3:;
> +ERROR3:
> kfree(new_client);
> -ERROR0:;
> +ERROR0:
> return err;
> }
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][trivial] matroxfb_maven remove pointless semicolons after label
2005-03-20 19:17 ` Petr Vandrovec
@ 2005-03-20 19:34 ` Jesper Juhl
0 siblings, 0 replies; 3+ messages in thread
From: Jesper Juhl @ 2005-03-20 19:34 UTC (permalink / raw)
To: Petr Vandrovec; +Cc: linux-fbdev-devel, linux-kernel
On Sun, 20 Mar 2005, Petr Vandrovec wrote:
> On Sun, Mar 20, 2005 at 05:41:01PM +0100, Jesper Juhl wrote:
> >
> > Having a semicolon at the end as in labelname:; is pointless, remove.
>
> As long as I'm maintainer of this code, I prefer to leave them here.
> Petr Vandrovec
>
No problem. As you say, you're the maintainer. I just spotted them and
made the patch, it's ofcourse entirely up to you if you want to apply it
or not :-)
--
Jesper Juhl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-03-20 19:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-20 16:41 [PATCH][trivial] matroxfb_maven remove pointless semicolons after label Jesper Juhl
2005-03-20 19:17 ` Petr Vandrovec
2005-03-20 19:34 ` Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®