[PATCH]: Fix get_compat_sigevent()

[PATCH]: Fix get_compat_sigevent()

[David S. Miller]

I have no idea how a bug like this lasted so long.
Anyways, obvious memset()'ing of incorrect pointer.

Please apply, thanks.

Signed-off-by: David S. Miller <davem@davemloft.net>

===== kernel/compat.c 1.46 vs edited =====
--- 1.46/kernel/compat.c	2005-03-13 15:29:47 -08:00
+++ edited/kernel/compat.c	2005-04-04 22:36:13 -07:00
@@ -640,7 +640,7 @@
 int get_compat_sigevent(struct sigevent *event,
 		const struct compat_sigevent __user *u_event)
 {
-	memset(&event, 0, sizeof(*event));
+	memset(event, 0, sizeof(*event));
 	return (!access_ok(VERIFY_READ, u_event, sizeof(*u_event)) ||
 		__get_user(event->sigev_value.sival_int,
 			&u_event->sigev_value.sival_int) ||

Re: [PATCH]: Fix get_compat_sigevent()

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

On Mon, 4 Apr 2005 22:44:09 -0700 "David S. Miller" <davem@davemloft.net> wrote:
>
> I have no idea how a bug like this lasted so long.

Probably because very few programs pass sigevents into the kernel ...

> -	memset(&event, 0, sizeof(*event));
> +	memset(event, 0, sizeof(*event));

Blush :-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH]: Fix get_compat_sigevent()

[David S. Miller]

On Tue, 5 Apr 2005 17:37:24 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> On Mon, 4 Apr 2005 22:44:09 -0700 "David S. Miller" <davem@davemloft.net> wrote:
> >
> > I have no idea how a bug like this lasted so long.
> 
> Probably because very few programs pass sigevents into the kernel ...

Perhaps, but this triggered an OOPS the first time I tried to
run the glibc testsuite on a compat platform.

Something for the LTP folks to add I guess.  :) I do run that all
the time.