From: Andrew Morton <akpm@osdl.org>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: zwane@arm.linux.org.uk, mingo@redhat.com, rml@tech9.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] silence spinlock/rwlock uninitialized break_lock member warnings
Date: Fri, 8 Apr 2005 17:10:26 -0700 [thread overview]
Message-ID: <20050408171026.5b822eeb.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.62.0504090150520.2455@dragon.hyggekrogen.localhost>
Jesper Juhl <juhl-lkml@dif.dk> wrote:
>
> Any chance this patch could be added to -mm (and possibly mainline)?
Spose I can stick it in -mm.
> It removes a bunch of warnings when building with gcc -W, like these:
> include/linux/wait.h:82: warning: missing initializer
> include/linux/wait.h:82: warning: (near initialization for `(anonymous).break_lock')
> include/asm/rwsem.h:88: warning: missing initializer
> include/asm/rwsem.h:88: warning: (near initialization for `(anonymous).break_lock')
> so there's less to sift through when looking for real problems with this
> patch applied.
> I've been using it for a while with no ill effects.
But I'd rather not add a bunch of even-more-ifdefs to support a compiler
flag which we're not going to use. It's easy enough for the `gcc -W' user
to add the patch himself.
next prev parent reply other threads:[~2005-04-09 0:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-09 0:01 Jesper Juhl
2005-04-09 0:10 ` Andrew Morton [this message]
2005-04-09 0:23 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050408171026.5b822eeb.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rml@tech9.net \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®