* [patch 005/198] arm: add comment about dma_supported()
@ 2005-04-12 10:30 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2005-04-12 10:30 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, akpm, rmk+lkml, rmk
From: Russell King <rmk+lkml@arm.linux.org.uk>
The ARM dma_supported() is rather basic, and I don't think it takes into
account everything that it should do (eg, whether the mask agrees with what
we'd return for GFP_DMA allocations). Note this.
Signed-off-by: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/include/asm-arm/dma-mapping.h | 3 +++
1 files changed, 3 insertions(+)
diff -puN include/asm-arm/dma-mapping.h~arm-add-comment-about-dma_supported include/asm-arm/dma-mapping.h
--- 25/include/asm-arm/dma-mapping.h~arm-add-comment-about-dma_supported 2005-04-12 03:21:04.755413968 -0700
+++ 25-akpm/include/asm-arm/dma-mapping.h 2005-04-12 03:21:04.758413512 -0700
@@ -21,6 +21,9 @@ extern void consistent_sync(void *kaddr,
* properly. For example, if your device can only drive the low 24-bits
* during bus mastering, then you would pass 0x00ffffff as the mask
* to this function.
+ *
+ * FIXME: This should really be a platform specific issue - we should
+ * return false if GFP_DMA allocations may not satisfy the supplied 'mask'.
*/
static inline int dma_supported(struct device *dev, u64 mask)
{
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-04-12 20:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-12 10:30 [patch 005/198] arm: add comment about dma_supported() akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®