From: akpm@osdl.org
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, agruen@suse.de
Subject: [patch 009/198] Fix acl Oops
Date: Tue, 12 Apr 2005 03:30:40 -0700 [thread overview]
Message-ID: <200504121030.j3CAUkUl005147@shell0.pdx.osdl.net> (raw)
From: Andreas Gruenbacher <agruen@suse.de>
ext[23]_get_acl will return an error when reading the attribute fails or
out-of-memory occurs. Catch this case.
Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/fs/ext2/acl.c | 2 ++
25-akpm/fs/ext3/acl.c | 2 ++
2 files changed, 4 insertions(+)
diff -puN fs/ext2/acl.c~fix-acl-oops fs/ext2/acl.c
--- 25/fs/ext2/acl.c~fix-acl-oops 2005-04-12 03:21:05.616283096 -0700
+++ 25-akpm/fs/ext2/acl.c 2005-04-12 03:21:05.621282336 -0700
@@ -283,6 +283,8 @@ ext2_check_acl(struct inode *inode, int
{
struct posix_acl *acl = ext2_get_acl(inode, ACL_TYPE_ACCESS);
+ if (IS_ERR(acl))
+ return PTR_ERR(acl);
if (acl) {
int error = posix_acl_permission(inode, acl, mask);
posix_acl_release(acl);
diff -puN fs/ext3/acl.c~fix-acl-oops fs/ext3/acl.c
--- 25/fs/ext3/acl.c~fix-acl-oops 2005-04-12 03:21:05.618282792 -0700
+++ 25-akpm/fs/ext3/acl.c 2005-04-12 03:21:05.622282184 -0700
@@ -286,6 +286,8 @@ ext3_check_acl(struct inode *inode, int
{
struct posix_acl *acl = ext3_get_acl(inode, ACL_TYPE_ACCESS);
+ if (IS_ERR(acl))
+ return PTR_ERR(acl);
if (acl) {
int error = posix_acl_permission(inode, acl, mask);
posix_acl_release(acl);
_
reply other threads:[~2005-04-12 18:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504121030.j3CAUkUl005147@shell0.pdx.osdl.net \
--to=akpm@osdl.org \
--cc=agruen@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®