* [patch 009/198] Fix acl Oops
@ 2005-04-12 10:30 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2005-04-12 10:30 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel, akpm, agruen
From: Andreas Gruenbacher <agruen@suse.de>
ext[23]_get_acl will return an error when reading the attribute fails or
out-of-memory occurs. Catch this case.
Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/fs/ext2/acl.c | 2 ++
25-akpm/fs/ext3/acl.c | 2 ++
2 files changed, 4 insertions(+)
diff -puN fs/ext2/acl.c~fix-acl-oops fs/ext2/acl.c
--- 25/fs/ext2/acl.c~fix-acl-oops 2005-04-12 03:21:05.616283096 -0700
+++ 25-akpm/fs/ext2/acl.c 2005-04-12 03:21:05.621282336 -0700
@@ -283,6 +283,8 @@ ext2_check_acl(struct inode *inode, int
{
struct posix_acl *acl = ext2_get_acl(inode, ACL_TYPE_ACCESS);
+ if (IS_ERR(acl))
+ return PTR_ERR(acl);
if (acl) {
int error = posix_acl_permission(inode, acl, mask);
posix_acl_release(acl);
diff -puN fs/ext3/acl.c~fix-acl-oops fs/ext3/acl.c
--- 25/fs/ext3/acl.c~fix-acl-oops 2005-04-12 03:21:05.618282792 -0700
+++ 25-akpm/fs/ext3/acl.c 2005-04-12 03:21:05.622282184 -0700
@@ -286,6 +286,8 @@ ext3_check_acl(struct inode *inode, int
{
struct posix_acl *acl = ext3_get_acl(inode, ACL_TYPE_ACCESS);
+ if (IS_ERR(acl))
+ return PTR_ERR(acl);
if (acl) {
int error = posix_acl_permission(inode, acl, mask);
posix_acl_release(acl);
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-04-12 18:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-12 10:30 [patch 009/198] Fix acl Oops akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®