mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [patch 132/198] quota: possible bug in quota format v2 support
@ 2005-04-12 10:32 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2005-04-12 10:32 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, akpm, niu, jack


From: Niu YaWei <niu@clusterfs.com>

Don't put root block of quota tree to the free list (when quota file is
completely empty).  That should not actually happen anyway (somebody should
get accounted for the filesystem root and so quota file should never be
empty) but better prevent it here than solve magical quota file
corruption.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 25-akpm/fs/quota_v2.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -puN fs/quota_v2.c~quota-possible-bug-in-quota-format-v2-support fs/quota_v2.c
--- 25/fs/quota_v2.c~quota-possible-bug-in-quota-format-v2-support	2005-04-12 03:21:35.447748024 -0700
+++ 25-akpm/fs/quota_v2.c	2005-04-12 03:21:35.450747568 -0700
@@ -503,7 +503,8 @@ static int remove_tree(struct dquot *dqu
 		int i;
 		ref[GETIDINDEX(dquot->dq_id, depth)] = cpu_to_le32(0);
 		for (i = 0; i < V2_DQBLKSIZE && !buf[i]; i++);	/* Block got empty? */
-		if (i == V2_DQBLKSIZE) {
+		/* Don't put the root block into the free block list */
+		if (i == V2_DQBLKSIZE && *blk != V2_DQTREEOFF) {
 			put_free_dqblk(sb, type, buf, *blk);
 			*blk = 0;
 		}
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-04-12 18:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-12 10:32 [patch 132/198] quota: possible bug in quota format v2 support akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®