From: Andi Kleen <ak@suse.de>
To: "Zou, Nanhai" <nanhai.zou@intel.com>
Cc: Andi Kleen <ak@suse.de>,
discuss@x86-64.org, linux-kernel@vger.kernel.org, "Siddha,
Suresh B" <suresh.b.siddha@intel.com>
Subject: Re: [discuss] [Patch] X86_64 TASK_SIZE cleanup - more comments
Date: Thu, 21 Apr 2005 13:54:25 +0200 [thread overview]
Message-ID: <20050421115425.GT7715@wotan.suse.de> (raw)
In-Reply-To: <894E37DECA393E4D9374E0ACBBE74270013E8B90@pdsmsx402.ccr.corp.intel.com>
Another comment:
In general I am not too happy about the variable size TASK_SIZE.
There was a patch for this earlier, but it broke 32bit emulation
completely. And I think it needs auditing of all uses of TASK_SIZE,
because I suspect there are more bugs lurking in it.
The way hugetlb etc. mmap were supposed to be handled was to
let the mmap succeed and then check in the mmap wrapper
if any address is > 4GB and free it. Probably that code
has some problems or got broken (I think it worked at least
in 2.4, but there might have been regressions later)
-Andi
next prev parent reply other threads:[~2005-04-21 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-20 17:17 [discuss] [Patch] X86_64 TASK_SIZE cleanup Zou, Nanhai
2005-04-21 11:50 ` Andi Kleen
2005-04-21 11:54 ` Andi Kleen [this message]
2005-04-21 16:09 [discuss] [Patch] X86_64 TASK_SIZE cleanup - more comments Zou, Nanhai
2005-04-23 9:10 ` Alexander Nyberg
2005-04-27 16:20 Zou, Nanhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050421115425.GT7715@wotan.suse.de \
--to=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nanhai.zou@intel.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®