From: Andi Kleen <ak@suse.de>
To: "Zou, Nanhai" <nanhai.zou@intel.com>
Cc: Andi Kleen <ak@suse.de>,
discuss@x86-64.org, linux-kernel@vger.kernel.org, "Siddha,
Suresh B" <suresh.b.siddha@intel.com>
Subject: Re: [discuss] [Patch] X86_64 TASK_SIZE cleanup
Date: Thu, 21 Apr 2005 13:50:30 +0200 [thread overview]
Message-ID: <20050421115030.GS7715@wotan.suse.de> (raw)
In-Reply-To: <894E37DECA393E4D9374E0ACBBE74270013E8B90@pdsmsx402.ccr.corp.intel.com>
On Thu, Apr 21, 2005 at 01:17:40AM +0800, Zou, Nanhai wrote:
> Hi Andi,
> What is your comment on this patch?
There is at least one wrong change in there, you have a check
for test_thread_flag(TIF_IA32) && (flags & MAP_32BIT)
and that is wrong because MAP_32BIT is used from 64bit code
-Andi
next prev parent reply other threads:[~2005-04-21 11:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-20 17:17 Zou, Nanhai
2005-04-21 11:50 ` Andi Kleen [this message]
2005-04-21 11:54 ` [discuss] [Patch] X86_64 TASK_SIZE cleanup - more comments Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2005-04-21 15:43 [discuss] [Patch] X86_64 TASK_SIZE cleanup Zou, Nanhai
2005-04-18 16:37 Zou, Nanhai
2005-04-16 1:34 Zou, Nanhai
2005-04-18 9:06 ` [discuss] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050421115030.GS7715@wotan.suse.de \
--to=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nanhai.zou@intel.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®