* Re: [TG3]: Add msi test
[not found] <200504220501.j3M51lkG012997@hera.kernel.org>
@ 2005-04-22 7:54 ` Arjan van de Ven
2005-04-22 17:46 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arjan van de Ven @ 2005-04-22 7:54 UTC (permalink / raw)
To: Linux Kernel Mailing List
On Thu, 2005-04-21 at 22:01 -0700, Linux Kernel Mailing List wrote:
> tree 1e1c24ad874db00f827fc6d9087402db6becefc9
> parent 88b06bc26b87cf0490b0e3faea7fefc7549dd75d
> author Michael Chan <mchan@broadcom.com> Fri, 22 Apr 2005 07:13:59 -0700
> committer David S. Miller <davem@sunset.davemloft.net> Fri, 22 Apr 2005 07:13:59 -0700
>
> [TG3]: Add msi test
>
> Add MSI test for chips that support MSI. If MSI test fails, it will
> switch back to INTx mode and will print a message asking the user to
> report the failure.
While the technicals of this change are ok, this still concerns me. Are
all MSI drivers now supposed to check if the bios/mobo actually support
MSI like this? That sounds sort of wrong!
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [TG3]: Add msi test
2005-04-22 7:54 ` [TG3]: Add msi test Arjan van de Ven
@ 2005-04-22 17:46 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2005-04-22 17:46 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: linux-kernel
On Fri, 22 Apr 2005 09:54:12 +0200
Arjan van de Ven <arjan@infradead.org> wrote:
> While the technicals of this change are ok, this still concerns me. Are
> all MSI drivers now supposed to check if the bios/mobo actually support
> MSI like this? That sounds sort of wrong!
It's a temporary situation I believe. Later on when our blacklist
is more comprehensive we can remove this kind of test code.
The test does spit a message out, so we will likely get a report
and therefore be able to update our MSI blacklists as appropriate.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-04-22 17:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200504220501.j3M51lkG012997@hera.kernel.org>
2005-04-22 7:54 ` [TG3]: Add msi test Arjan van de Ven
2005-04-22 17:46 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®