mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
	Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: handle iret faults better
Date: Mon, 25 Apr 2005 17:33:10 +0200	[thread overview]
Message-ID: <20050425153310.GB16828@wotan.suse.de> (raw)
In-Reply-To: <200504240050.j3O0obqR032684@magilla.sf.frob.com>

On Sat, Apr 23, 2005 at 05:50:37PM -0700, Roland McGrath wrote:
> This is the x86_64 variant of the i386 fix I just submitted.  I think
> iret can only produce these faults when returning to user mode in a
> 32-bit process.  The failure mode is even more mysterious on x86_64,
> because it exits with -9999&0x7f instead of 11 (SIGSEGV), so it says
> "Unknown signal 113 (core dumped)" when it exits without actually
> trying to dump a core file.

I agree that handling this better is a good idea.

But I really hate your is_iret hack in traps.c. Cant you just force the signal
after fixing up the stack? I dont want such a ugly complicated special case 
there that only handles this extremly exotic case.
If you cant do it in a cleaner way it would be better not to fix it.
But I suppose forcing a signal directly is doable.

-Andi

  reply	other threads:[~2005-04-25 15:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-24  0:50 Roland McGrath
2005-04-25 15:33 ` Andi Kleen [this message]
2005-04-25 15:55   ` Linus Torvalds
2005-04-25 22:31     ` Roland McGrath
2005-04-25 22:51       ` Linus Torvalds
2005-04-26  1:57         ` Roland McGrath
2005-04-26  4:06           ` Linus Torvalds
2005-04-29  3:40             ` [PATCH] i386: " Roland McGrath
2005-04-29 15:01               ` Andi Kleen
2005-04-29 16:44               ` Linus Torvalds
2005-05-02 19:56                 ` Andi Kleen
2005-04-29  3:45             ` [PATCH] x86_64: " Roland McGrath
2005-04-29 15:02               ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050425153310.GB16828@wotan.suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®