From: Linus Torvalds <torvalds@osdl.org>
To: Andi Kleen <ak@suse.de>, Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: handle iret faults better
Date: Mon, 25 Apr 2005 08:55:22 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0504250849370.18901@ppc970.osdl.org> (raw)
In-Reply-To: <20050425153310.GB16828@wotan.suse.de>
On Mon, 25 Apr 2005, Andi Kleen wrote:
>
> But I really hate your is_iret hack in traps.c.
I agree.
Why don't you just do
pushl $0
pushl $do_iret_error
jmp error_code
And just have a "do_iret_error()" handler in traps.c which does the right
thing? That seems like the _sane_ thing to do, and that way there is never
any confusion about what is going on.
Linus
next prev parent reply other threads:[~2005-04-25 15:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-24 0:50 Roland McGrath
2005-04-25 15:33 ` Andi Kleen
2005-04-25 15:55 ` Linus Torvalds [this message]
2005-04-25 22:31 ` Roland McGrath
2005-04-25 22:51 ` Linus Torvalds
2005-04-26 1:57 ` Roland McGrath
2005-04-26 4:06 ` Linus Torvalds
2005-04-29 3:40 ` [PATCH] i386: " Roland McGrath
2005-04-29 15:01 ` Andi Kleen
2005-04-29 16:44 ` Linus Torvalds
2005-05-02 19:56 ` Andi Kleen
2005-04-29 3:45 ` [PATCH] x86_64: " Roland McGrath
2005-04-29 15:02 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0504250849370.18901@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®