From: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: Jeff Dike <jdike@addtoit.com>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/22] UML - Include the linker script rather than symlink it
Date: Tue, 3 May 2005 01:25:21 +0100 [thread overview]
Message-ID: <20050503002521.GA18977@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20050502170654.248b11ea.akpm@osdl.org>
On Mon, May 02, 2005 at 05:06:54PM -0700, Andrew Morton wrote:
> That file doesn't exist and I think this patch doesn't want to patch it
> anyway.
>
> I'll just drop the vmlinux.lds.S chunk...
Correct patch is on ftp.linux.org.uk/pub/people/viro/UM0-uml-ldscript-RC12-rc3
Short version of the story: current tree plays with a symlink from
vmlinux.lds.S to one of two files, depending on the config. That doesn't
work well and confused vmlinux.lds.S chunk is actually a demonstration of
breakage - symlink had not been properly cleaned up.
New variant has _fixed_ vmlinux.lds.S - real file with
#include <linux/config.h>
#ifdef CONFIG_LD_SCRIPT_STATIC
#include "uml.lds.S"
#else
#include "dyn.lds.S"
#endif
in it and no symlink magic in makefiles. Since we feed it through cpp
anyway, we can simply let cpp do all work - including picking the right
script depending on config.
next prev parent reply other threads:[~2005-05-03 0:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-01 21:12 Jeff Dike
2005-05-03 0:06 ` Andrew Morton
2005-05-03 0:25 ` Al Viro [this message]
2005-05-03 0:44 ` Andrew Morton
2005-05-03 1:17 ` Al Viro
2005-05-03 1:28 ` Andrew Morton
2005-05-03 1:45 ` Al Viro
2005-05-03 2:02 ` Andrew Morton
2005-05-03 3:03 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050503002521.GA18977@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®