From: Jiri Benc <jbenc@suse.cz>
To: v4l <video4linux-list@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] video/tuner: fix tuner->freq updating
Date: Fri, 6 May 2005 16:06:49 +0200 [thread overview]
Message-ID: <20050506160649.7a3f0ff8@griffin.suse.cz> (raw)
In VIDIOC_S_FREQUENCY command in tuner-core.c, t->freq is set to a new
value before calling set_freq(). This is not necessary, as set_freq()
sets t->freq itself. Moreover, it causes problems with Philips tuners,
as they need to take into consideration difference between previous and
new frequency.
Signed-off-by: Jiri Benc <jbenc@suse.cz>
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -357,8 +357,7 @@
V4L2_TUNER_RADIO != t->mode)
set_tv_freq(client,400*16);
t->mode = f->type;
- t->freq = f->frequency;
- set_freq(client,t->freq);
+ set_freq(client,f->frequency);
break;
}
case VIDIOC_G_TUNER:
--
Jiri Benc
SUSE Labs
reply other threads:[~2005-05-06 14:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050506160649.7a3f0ff8@griffin.suse.cz \
--to=jbenc@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®