* [PATCH 1/2] video/tuner: fix tuner->freq updating
@ 2005-05-06 14:06 Jiri Benc
0 siblings, 0 replies; only message in thread
From: Jiri Benc @ 2005-05-06 14:06 UTC (permalink / raw)
To: v4l; +Cc: LKML
In VIDIOC_S_FREQUENCY command in tuner-core.c, t->freq is set to a new
value before calling set_freq(). This is not necessary, as set_freq()
sets t->freq itself. Moreover, it causes problems with Philips tuners,
as they need to take into consideration difference between previous and
new frequency.
Signed-off-by: Jiri Benc <jbenc@suse.cz>
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -357,8 +357,7 @@
V4L2_TUNER_RADIO != t->mode)
set_tv_freq(client,400*16);
t->mode = f->type;
- t->freq = f->frequency;
- set_freq(client,t->freq);
+ set_freq(client,f->frequency);
break;
}
case VIDIOC_G_TUNER:
--
Jiri Benc
SUSE Labs
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-05-06 14:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-06 14:06 [PATCH 1/2] video/tuner: fix tuner->freq updating Jiri Benc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®