mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/4] iseries_veth: Set dev->trans_start so watchdog timer works right
@ 2005-05-12  7:53 Michael Ellerman
  0 siblings, 0 replies; only message in thread
From: Michael Ellerman @ 2005-05-12  7:53 UTC (permalink / raw)
  To: Andrew Morton, Jeff Garzik; +Cc: netdev, linux-kernel

Hi Andrew, Jeff,

The iseries_veth driver doesn't set dev->trans_start in it's TX path. This
will cause the net device watchdog timer to fire earlier than we want it to,
which causes the driver to needlessly reset its connections to other LPARs.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
--

 iseries_veth.c |    2 ++
 1 files changed, 2 insertions(+)

Index: veth-fixes/drivers/net/iseries_veth.c
===================================================================
--- veth-fixes.orig/drivers/net/iseries_veth.c
+++ veth-fixes/drivers/net/iseries_veth.c
@@ -1023,6 +1023,8 @@ static int veth_start_xmit(struct sk_buf
 
 	lpmask = veth_transmit_to_many(skb, lpmask, dev);
 
+	dev->trans_start = jiffies;
+
 	if (! lpmask) {
 		dev_kfree_skb(skb);
 	} else {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-05-12  7:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-12  7:53 [PATCH 2/4] iseries_veth: Set dev->trans_start so watchdog timer works right Michael Ellerman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®