mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Christoph Lameter <christoph@lameter.com>, dely.l.sy@intel.com
Cc: Oleg Nesterov <oleg@tv-sign.ru>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, mingo@elte.hu,
	kenneth.w.chen@intel.com, shai@scalex86.org
Subject: Re: [RFC][PATCH] timers fixes/improvements
Date: Fri, 13 May 2005 15:36:12 -0700	[thread overview]
Message-ID: <20050513223611.GB15601@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0505110804540.10451@graphe.net>

On Wed, May 11, 2005 at 08:12:16AM -0700, Christoph Lameter wrote:
> We found that this has nothing to do with the timer patches. There is a
> scribble in pcie_rootport_aspm_quirk that overwrites ptype_all.

Ick.

> quirk_aspm_offset[GET_INDEX(pdev->device, dev->devfn)]= cap_base + 0x10;
> 
> does the evil deed. The array offset calculated by GET_INDEX is out of
> bounds.
> 
> The definition of GET_INDEX is suspect:
> 
> #define GET_INDEX(a, b) (((a - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) + b)
> 
> should this not be
> 
> #define GET_INDEX(a, b) ((((a) - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) + \
> 				((b) & 7))
> 
> ?

Dely, any thoughts about this, or know who would know about it?

thanks,

greg k-h

  reply	other threads:[~2005-05-13 22:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-01 11:57 Oleg Nesterov
2005-04-01 11:59 ` Oleg Nesterov
2005-04-01 13:07   ` Ingo Molnar
2005-04-01 13:52     ` Oleg Nesterov
2005-04-01 12:58 ` Ingo Molnar
2005-04-01 16:08 ` Linus Torvalds
2005-04-01 18:32   ` Andrew Morton
2005-04-01 18:41     ` Christoph Lameter
2005-04-01 18:44     ` Chen, Kenneth W
2005-04-02  9:22 ` Oleg Nesterov
2005-05-09 20:35   ` Christoph Lameter
2005-05-09 21:42     ` Andrew Morton
2005-05-09 21:51       ` Christoph Lameter
2005-05-10 10:23         ` Oleg Nesterov
2005-05-10 19:15           ` Christoph Lameter
2005-05-10 21:48             ` George Anzinger
2005-05-11 10:18             ` Oleg Nesterov
2005-05-11 15:12               ` Christoph Lameter
2005-05-13 22:36                 ` Greg KH [this message]
     [not found]             ` <20050510.125301.59655362.davem@davemloft.net>
2005-05-11 15:06               ` Oleg Nesterov
2005-05-12 23:36                 ` Ganesh Venkatesan
2005-05-09 23:10       ` Christoph Lameter
2005-04-02 10:07 ` Andrew Morton
2005-04-02 11:02   ` Oleg Nesterov
2005-04-02 14:58   ` Ingo Molnar
2005-05-17 15:38 Sy, Dely L
2005-05-17 15:50 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050513223611.GB15601@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=christoph@lameter.com \
    --cc=dely.l.sy@intel.com \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=shai@scalex86.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®