mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Sy, Dely L" <dely.l.sy@intel.com>
To: "Greg KH" <greg@kroah.com>, "Christoph Lameter" <christoph@lameter.com>
Cc: "Oleg Nesterov" <oleg@tv-sign.ru>,
	"Andrew Morton" <akpm@osdl.org>, <linux-kernel@vger.kernel.org>,
	<mingo@elte.hu>, "Chen, Kenneth W" <kenneth.w.chen@intel.com>,
	<shai@scalex86.org>
Subject: RE: [RFC][PATCH] timers fixes/improvements
Date: Tue, 17 May 2005 08:38:45 -0700	[thread overview]
Message-ID: <468F3FDA28AA87429AD807992E22D07E054DA776@orsmsx408> (raw)

On Friday, May 13, 2005 3:36 PM, Greg KH wrote:
> > The definition of GET_INDEX is suspect:
> > 
> > #define GET_INDEX(a, b) (((a - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) +
b)
> > 
> > should this not be
> > 
> > #define GET_INDEX(a, b) ((((a) - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) +
\
> > 				((b) & 7))
> > 
> > ?
>
> Dely, any thoughts about this, or know who would know about it?

Greg,

I looked at the code and talked with Steve on this.  The fix is correct;
i.e. b has to be masked with 7.  Would Christoph or you send out a 
patch for the fix or would you like us to do so?  Thanks for finding out

the problem.

Thanks,
Dely

             reply	other threads:[~2005-05-17 15:40 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-17 15:38 Sy, Dely L [this message]
2005-05-17 15:48 ` [PATCH] fix memory scribble in arch/i386/pci/fixup.c Christoph Lameter
2005-05-17 15:50 ` [RFC][PATCH] timers fixes/improvements Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2005-04-01 11:57 Oleg Nesterov
2005-04-01 11:59 ` Oleg Nesterov
2005-04-01 13:07   ` Ingo Molnar
2005-04-01 13:52     ` Oleg Nesterov
2005-04-01 12:58 ` Ingo Molnar
2005-04-01 16:08 ` Linus Torvalds
2005-04-01 18:32   ` Andrew Morton
2005-04-01 18:41     ` Christoph Lameter
2005-04-01 18:44     ` Chen, Kenneth W
2005-04-02  9:22 ` Oleg Nesterov
2005-05-09 20:35   ` Christoph Lameter
2005-05-09 21:42     ` Andrew Morton
2005-05-09 21:51       ` Christoph Lameter
2005-05-10 10:23         ` Oleg Nesterov
2005-05-10 19:15           ` Christoph Lameter
2005-05-10 21:48             ` George Anzinger
2005-05-11 10:18             ` Oleg Nesterov
2005-05-11 15:12               ` Christoph Lameter
2005-05-13 22:36                 ` Greg KH
     [not found]             ` <20050510.125301.59655362.davem@davemloft.net>
2005-05-11 15:06               ` Oleg Nesterov
2005-05-12 23:36                 ` Ganesh Venkatesan
2005-05-09 23:10       ` Christoph Lameter
2005-04-02 10:07 ` Andrew Morton
2005-04-02 11:02   ` Oleg Nesterov
2005-04-02 14:58   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468F3FDA28AA87429AD807992E22D07E054DA776@orsmsx408 \
    --to=dely.l.sy@intel.com \
    --cc=akpm@osdl.org \
    --cc=christoph@lameter.com \
    --cc=greg@kroah.com \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=shai@scalex86.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®